From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95970-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30414 invoked by alias); 15 Nov 2012 16:04:23 -0000
Received: (qmail 30401 invoked by uid 22791); 15 Nov 2012 16:04:21 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 16:04:14 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAFG4DCS026954	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 15 Nov 2012 11:04:13 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAFG4BXI024952;	Thu, 15 Nov 2012 11:04:12 -0500
Message-ID: <50A5127B.4000309@redhat.com>
Date: Thu, 15 Nov 2012 16:04:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2
MIME-Version: 1.0
To: Yao Qi <yao@codesourcery.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH] Skip gcore-buffer-overflow.exp on windows
References: <1352991707-29104-1-git-send-email-yao@codesourcery.com>
In-Reply-To: <1352991707-29104-1-git-send-email-yao@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00408.txt.bz2

On 15-11-2012 15:01, Yao Qi wrote:
>  
> +# Skip this test on Windows; the long filename is not allowed.
> +if { [ishost "i?86-*-mingw*"] } {
> +    untested gcore-buffer-overflow.exp


In untested calls, please spell out the reason the test ends up untested,
instead of just writing the test name, as with the latter we just end up with
the test name duplicated in the gdb.sum output.

> +    return -1
> +}

-- 
Pedro Alves