From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21862 invoked by alias); 15 Nov 2012 10:15:50 -0000 Received: (qmail 21846 invoked by uid 22791); 15 Nov 2012 10:15:49 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 10:15:39 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAFAFZqK003313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 15 Nov 2012 05:15:35 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAFAFYKS027757; Thu, 15 Nov 2012 05:15:34 -0500 Message-ID: <50A4C0C5.8020901@redhat.com> Date: Thu, 15 Nov 2012 10:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [RFA] ARI fixes: move gdb_stat.h and gdb_wait.h to common subdirectory. References: <50a4aadb.c54c420a.715f.5d53SMTPIN_ADDED@mx.google.com> In-Reply-To: <50a4aadb.c54c420a.715f.5d53SMTPIN_ADDED@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00393.txt.bz2 On 15-11-2012 08:41, Pierre Muller wrote: > 2012-11-14 Pierre Muller > > ARI fixes: move gdb_wait and gdb_stat headers to common > subdirectory. > * gdb_stat.h: Delete. Moved to common directory. > * common/gdb_stat.h: New file. > * gdb_wait.h: Delete. Moved to common directory. > * common/gdb_wait.h: New file. > * Makefile.in (H_FILES_NO_SRC): Adapt to new header > location. > * contrib/ari/gdb_ari.sh (wait.h rule): Adapt to new gdb_wait.h > location. > (stat.h rule): Adapt to new gdb_stat.h location. > * common/linux-osdata.c: Include "gdb_stat.h" header instead of > header. > * common/linux-ptrace.c: Include "gdb_wait.h" header instead of > header. Note tabs vs spaces. When moving headers to common/, we need to ensure that whatever config.h HAVE_FOO symbols they are using are also produced by gdbserver's configure too. gdb_wait.h seems to depend on AC_CHECK_HEADERS checks for sys/wait.h and wait.h. gdbserver's configure only checks the former. gdb_stat.h seems to depend on AC_HEADER_STAT for STAT_MACROS_BROKEN. gdbserver's configure doesn't call that macro. But, according to autoconf's manual: > Macro: AC_HEADER_STAT > > If the macros S_ISDIR, S_ISREG, etc. defined in sys/stat.h do not work properly > (returning false positives), define STAT_MACROS_BROKEN. This is > the case on Tektronix UTekV, Amdahl UTS and Motorola System V/88. > > This macro is obsolescent, as no current systems have the bug. New > programs need not use this macro. These old hosts are not relevant for GDB anymore (I found references to Motorola 88000 but support was removed on 6.0). So we can just remove the AC_HEADER_STAT call from gdb's configure.ac, and remove the whole STAT_MACROS_BROKEN block from gdb_stat.h. That would be done as a separate patch (in a separate email thread). I'd prefer that be done before the move, thus avoiding adding AC_HEADER_STAT to gdbserver. -- Pedro Alves