From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23856 invoked by alias); 14 Nov 2012 19:21:53 -0000 Received: (qmail 23847 invoked by uid 22791); 14 Nov 2012 19:21:52 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Nov 2012 19:21:45 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TYiWs-0002Yz-27 from Luis_Gustavo@mentor.com ; Wed, 14 Nov 2012 11:21:42 -0800 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 14 Nov 2012 11:21:41 -0800 Received: from [0.0.0.0] ([172.16.63.104]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 14 Nov 2012 11:21:41 -0800 Message-ID: <50A3EF5D.4060607@codesourcery.com> Date: Wed, 14 Nov 2012 19:21:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Lightning/1.0b2 Thunderbird/3.1.20 MIME-Version: 1.0 To: Tom Tromey CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix mi "-var-create" regression References: <5075D4FD.9050900@mentor.com> <20121014171805.GB3050@adacore.com> <507BFF97.2000900@codesourcery.com> <87y5j4ziof.fsf@fleche.redhat.com> <508DB53E.30507@codesourcery.com> <87625rwvcp.fsf@fleche.redhat.com> In-Reply-To: <87625rwvcp.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00382.txt.bz2 On 10/30/2012 06:36 PM, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado writes: > > Luis> 2012-10-15 Luis Machado > Luis> * value.c (value_actual_type): Check for TYPE_CODE_STRUCT > Luis> target types. > > Luis> testsuite/ > Luis> * mi-var-create-rtti.c: New file. > Luis> * mi-var-create-rtti.exp: New file. > > This looks good to me. One tiny nit: > > Luis> Index: gdb/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp > Luis> + return -1; > > No need for a ";" here. > > Ok with this change. > > thanks, > Tom Thanks. I've checked this in now. Luis