From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7290 invoked by alias); 9 Nov 2012 18:53:23 -0000 Received: (qmail 7281 invoked by uid 22791); 9 Nov 2012 18:53:22 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Nov 2012 18:53:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA9IrFMZ021115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Nov 2012 13:53:16 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qA9IrE6F007788; Fri, 9 Nov 2012 13:53:15 -0500 Message-ID: <509D511A.2090209@redhat.com> Date: Fri, 09 Nov 2012 18:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: RFA: handle "MiniDebuginfo" section References: <87wqxuel5k.fsf@fleche.redhat.com> <20121109182316.GQ5103@adacore.com> In-Reply-To: <20121109182316.GQ5103@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00259.txt.bz2 On 11/09/2012 06:23 PM, Joel Brobecker wrote: > To avoid the #ifdef HAVE_LZMA, I might even provide two versions of the > file, one with the real implementation, and one with the phony one, and > have the configure choose which one to link in. This isn't what we've > been doing in the past (iconv, python), so to be taken with a grain of > salt. I think it'll make the code a little easier to navigate, however. See xml-tdesc.c, where we do something similar, but not in separate files (which I actually prefer, for being simpler). In that case, we warn once if xml support isn't built in. It could be useful here too, not sure: warning: Can not parse .gnu_debugdata section; LZMA support was disabled at compile time -- Pedro Alves