From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25459 invoked by alias); 9 Nov 2012 09:54:58 -0000 Received: (qmail 25451 invoked by uid 22791); 9 Nov 2012 09:54:57 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Nov 2012 09:54:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA99skuZ029187 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Nov 2012 04:54:46 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA99sjKP009980; Fri, 9 Nov 2012 04:54:45 -0500 Message-ID: <509CD2E4.5050808@redhat.com> Date: Fri, 09 Nov 2012 09:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Add breakpoint_created observer to update tracepoint_count. References: <1352249397-15044-1-git-send-email-yao@codesourcery.com> <509AA4C6.2030102@redhat.com> <509C57B2.5020806@codesourcery.com> <509C6A51.4090707@redhat.com> <509CB029.6050904@codesourcery.com> In-Reply-To: <509CB029.6050904@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00241.txt.bz2 On 11/09/2012 07:26 AM, Yao Qi wrote: > OK. I adjust test here a little to use MI commands to get the value of > $tpnum (before and after creating tracepoint) to avoid using regexp. > > Committed as below. Excellent, thanks. > + mi_create_varobj tpnum \$tpnum "create local variable tpnum" > + # Test that $tpnum is not set before creating a tracepoint. > + mi_gdb_test "521-var-evaluate-expression tpnum" \ > + "521\\^done,value=\"void\"" "eval tpnum before tracepoint" > + > + mi_gdb_test "522-break-insert -a main" \ > + "522\\^done,bkpt=\{number=\"10\",type=\"tracepoint\".*\"\}" \ > + "break-insert -a operation" > + > + mi_gdb_test "523-var-update tpnum" \ > + "523\\^done,changelist=\\\[\{name=\"tpnum\",in_scope=\"true\",type_changed=\"false\",has_more=\"0\"\}\\\]" \ > + "update tpnum" Interesting that type_changed is false. Looks like a bug. -- Pedro Alves