From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: [7.5] PATCH: PR backtrace/14646 [x32] backtrace doesn't work
Date: Fri, 09 Nov 2012 00:15:00 -0000 [thread overview]
Message-ID: <509C4B2D.9090809@redhat.com> (raw)
In-Reply-To: <20121021015636.GD3050@adacore.com>
On 10/21/2012 02:56 AM, Joel Brobecker wrote:
>> This patch backports the fix from trunk to 7.5 branch. Tested on
>> Linux/x86-64 and Linux/x32. OK to install?
> [...]
>> PR backtrace/14646
>> PR gdb/14647
>> * i386-tdep.h (gdbarch_tdep): Remove sp_regnum_from_eax and
>> pc_regnum_from_eax.
>> * i386-tdep.c (i386_gdbarch_init): Don't use sp_regnum_from_eax
>> nor pc_regnum_from_eax.
>> * amd64-tdep.c (amd64_x32_init_abi): Don't set sp_regnum_from_eax
>> nor pc_regnum_from_eax.
>
> I'm sorry to say that I am not comfortable at all with this going
> in the 7.5 branch. If Mark is super confident, then OK, but this is
> touching sp/pc handling for all x86 and x86-64 targets. And I don't
> think that the issue this patch is fixing is that critical.
I'm not Mark, but it looks safe on all x86 and x86-64 targets to me.
Note how tdep->sp_regnum_from_eax and tdep->sp_regnum_from_eax are -1
by default, and only x32 sets it to something else. Then, the only use
for those fields:
- if (tdep->sp_regnum_from_eax != -1)
- set_gdbarch_sp_regnum (gdbarch,
- (tdep->eax_regnum
- + tdep->sp_regnum_from_eax));
- if (tdep->pc_regnum_from_eax != -1)
- set_gdbarch_pc_regnum (gdbarch,
- (tdep->eax_regnum
- + tdep->pc_regnum_from_eax));
only had effect on x32.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-09 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 23:47 H.J. Lu
2012-10-21 1:56 ` Joel Brobecker
2012-10-21 2:06 ` H.J. Lu
2012-11-09 0:15 ` Pedro Alves [this message]
2012-11-09 9:59 ` Mark Kettenis
2012-11-09 16:54 ` Joel Brobecker
2012-11-10 0:53 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509C4B2D.9090809@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox