From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21876 invoked by alias); 8 Nov 2012 18:50:27 -0000 Received: (qmail 21866 invoked by uid 22791); 8 Nov 2012 18:50:26 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Nov 2012 18:50:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA8IoHcp016367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Nov 2012 13:50:18 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA8IoFal028924; Thu, 8 Nov 2012 13:50:16 -0500 Message-ID: <509BFEE7.60902@redhat.com> Date: Thu, 08 Nov 2012 18:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Doug Evans , gdb-patches@sourceware.org Subject: Re: [PATCH] Always include defs.h first. References: <20121107201107.25258.47267.stgit@brno.lan> <509BE290.4000104@redhat.com> <20121108183842.GM5103@adacore.com> In-Reply-To: <20121108183842.GM5103@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00203.txt.bz2 On 11/08/2012 06:38 PM, Joel Brobecker wrote: > [I agree consistency is good] > >> Note that gdbserver doesn't have defs.h and lots of files in common/ do the >> >> #ifdef GDBSERVER >> #include "server.h" >> #else >> #include "defs.h" >> #endif > > Perhaps we should rename server.h into defs.h? Or move defs.h to > common? I agree with adding a defs.h to gdbserver. defs.h depends on bfd and has lots of gdb-specifics, so no good for gdbserver as is. -- Pedro Alves