From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7034 invoked by alias); 7 Nov 2012 20:46:17 -0000 Received: (qmail 7025 invoked by uid 22791); 7 Nov 2012 20:46:16 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,TW_XF X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Nov 2012 20:45:58 +0000 Received: from /spool/local by e24smtp01.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Nov 2012 18:45:55 -0200 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp01.br.ibm.com (10.172.0.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 7 Nov 2012 18:45:52 -0200 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id B67CA3520054 for ; Wed, 7 Nov 2012 15:45:51 -0500 (EST) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.8.31.93]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qA7KjjBZ45678796 for ; Wed, 7 Nov 2012 18:45:45 -0200 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qA7KjoGm008580 for ; Wed, 7 Nov 2012 18:45:51 -0200 Received: from [9.8.15.210] ([9.8.15.210]) by d24av02.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id qA7Kjo0d008577; Wed, 7 Nov 2012 18:45:50 -0200 Message-ID: <509AC87D.5050403@linux.vnet.ibm.com> Date: Wed, 07 Nov 2012 20:46:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Ulrich Weigand CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PLT call stub for ppc64 References: <201211071921.qA7JLDSI011279@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201211071921.qA7JLDSI011279@d06av02.portsmouth.uk.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12110720-1524-0000-0000-0000044C8AFD X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00167.txt.bz2 On 11/07/2012 05:21 PM, Ulrich Weigand wrote: > Hmm, looking at the binutils patch, it seems to me that the static chain load > in the *other* PLT stubs (ppc64_standard_linkage1, ppc64_standard_linkage2) > should now also be marked as optional, shouldn't it? > Thanks a lot for the comment, Ulrich. Here's the new version of the patch, updating the other PLT stubs patterns accordingly. -- Edjunior gdb/ChangeLog 2012-11-07 Edjunior Machado * ppc-linux-tdep.c: Mark ld r11 instructions as optional, following the change in PLT call stubs on linker. --- gdb/ppc-linux-tdep.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c index ccded83..f88d697 100644 --- a/gdb/ppc-linux-tdep.c +++ b/gdb/ppc-linux-tdep.c @@ -390,8 +390,8 @@ static struct insn_pattern ppc64_standard_linkage1[] = /* mtctr r11 */ { insn_xfx (-1, -1, -1, -1), insn_xfx (31, 11, 9, 467), 0 }, - /* ld r11, (r12) */ - { insn_ds (-1, -1, -1, 0, -1), insn_ds (58, 11, 12, 0, 0), 0 }, + /* ld r11, (r12) */ + { insn_ds (-1, -1, -1, 0, -1), insn_ds (58, 11, 12, 0, 0), 1 }, /* bctr */ { -1, 0x4e800420, 0 }, @@ -421,8 +421,8 @@ static struct insn_pattern ppc64_standard_linkage2[] = /* ld r2, (r12) */ { insn_ds (-1, -1, -1, 0, -1), insn_ds (58, 2, 12, 0, 0), 0 }, - /* ld r11, (r12) */ - { insn_ds (-1, -1, -1, 0, -1), insn_ds (58, 11, 12, 0, 0), 0 }, + /* ld r11, (r12) */ + { insn_ds (-1, -1, -1, 0, -1), insn_ds (58, 11, 12, 0, 0), 1 }, /* bctr */ { -1, 0x4e800420, 0 }, @@ -446,8 +446,8 @@ static struct insn_pattern ppc64_standard_linkage3[] = /* mtctr r11 */ { insn_xfx (-1, -1, -1, -1), insn_xfx (31, 11, 9, 467), 0 }, - /* ld r11, (r2) */ - { insn_ds (-1, -1, -1, 0, -1), insn_ds (58, 11, 2, 0, 0), 0 }, + /* ld r11, (r2) */ + { insn_ds (-1, -1, -1, 0, -1), insn_ds (58, 11, 2, 0, 0), 1 }, /* ld r2, (r2) */ { insn_ds (-1, -1, -1, 0, -1), insn_ds (58, 2, 2, 0, 0), 0 }, -- 1.7.10.1