From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add breakpoint_created observer to update tracepoint_count.
Date: Wed, 07 Nov 2012 18:13:00 -0000 [thread overview]
Message-ID: <509AA4C6.2030102@redhat.com> (raw)
In-Reply-To: <1352249397-15044-1-git-send-email-yao@codesourcery.com>
On 11/07/2012 12:49 AM, Yao Qi wrote:
> Hi,
> I noticed a bug that 'tracepoint_count' is out of date if tracepoint
> is created by MI command '-break-insert -a'. This patch is to
> install 'update_tracepoint_count' to observer 'breakpoint_created',
> and 'update_tracepoint_count' can update 'tracepoint_count' if B
> is a tracepoint.
>
> Regression tested on x86_64-linux. Is it OK?
>
No need to install an observer for a notification that is emitted in the same
module the new observer is in. This is internals of the breakpoints module.
All set_breakpoint_count's calls are centralized in install_breakpoint, through
set_breakpoint_number. All but break-range's, that is. I don't recall why
that doesn't use install_breakpoint. Maybe it should.
We should be able to put 'if (is_tracepoint) set_tracepoint_count()' in
install_breakpoint too.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-07 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 0:50 Yao Qi
2012-11-07 18:13 ` Pedro Alves [this message]
2012-11-09 1:09 ` Yao Qi
2012-11-09 2:28 ` Pedro Alves
2012-11-09 7:26 ` Yao Qi
2012-11-09 9:54 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509AA4C6.2030102@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox