From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32681 invoked by alias); 7 Nov 2012 15:08:37 -0000 Received: (qmail 32666 invoked by uid 22791); 7 Nov 2012 15:08:36 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Nov 2012 15:08:28 +0000 Received: from [10.9.200.133] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Wed, 07 Nov 2012 07:06:13 -0800 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB02.corp.ad.broadcom.com (10.9.200.133) with Microsoft SMTP Server id 8.2.247.2; Wed, 7 Nov 2012 07:07:46 -0800 Received: from [10.177.73.84] (unknown [10.177.73.84]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id A890340FE4; Wed, 7 Nov 2012 07:08:13 -0800 (PST) Message-ID: <509A7960.3010306@broadcom.com> Date: Wed, 07 Nov 2012 15:08:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: "Eli Zaretskii" cc: palves@redhat.com, gdb-patches@sourceware.org Subject: Re: Add fullname field in disassembly output References: <506DB4B8.5030001@broadcom.com> <5085B9D5.80508@broadcom.com> <50913B7F.10707@redhat.com> <5093A785.3060103@broadcom.com> <5093E786.2090909@redhat.com> <5098FEF0.60503@broadcom.com> <83d2zq39un.fsf@gnu.org> In-Reply-To: <83d2zq39un.fsf@gnu.org> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00143.txt.bz2 On 06/11/2012 5:44 PM, Eli Zaretskii wrote: >> Date: Tue, 6 Nov 2012 12:13:36 +0000 >> From: "Andrew Burgess" >> cc: gdb-patches@sourceware.org, "Eli Zaretskii" >> > > The patch for the manual is OK with these changes. Thanks for the review, I'll make those changes. > >> +file="../../../src/gdb/testsuite/gdb.mi/basics.c", >> +fullname="/absolute/path/to/src/gdb/testsuite/gdb.mi/basics.c", >> +line_asm_insn=[@{address="0x000107bc", >> +func-name="main",offset="0",inst="save %sp, -112, %sp"@}]@}, >> src_and_asm_line=@{line="32", >> -file="/kwikemart/marge/ezannoni/flathead-dev/devo/gdb/ \ >> - testsuite/gdb.mi/basics.c",line_asm_insn=[ >> -@{address="0x000107c0",func-name="main",offset="4", >> -inst="mov 2, %o0"@}, >> +file="../../../src/gdb/testsuite/gdb.mi/basics.c", >> +fullname="/absolute/path/to/src/gdb/testsuite/gdb.mi/basics.c", >> +line_asm_insn=[@{address="0x000107c0", >> +func-name="main",offset="4",inst="mov 2, %o0"@}, >> @{address="0x000107c4",func-name="main",offset="8", >> inst="sethi %hi(0x11800), %o2"@}]@}] >> (gdb) > > Why do we sometimes use names with a hyphen, like func-name, and > sometimes with underscores, like line_asm_insn? Shouldn't we pick one > and use it consistently? That would probably be a good thing, but given I didn't add the code I'd rather not start changing these things. Also, given that this exists in the wild and the MI interface is supposed to remain consistent I suspect we're stuck with what we have... Just so I'm clear, should I consider this a block to committing this patch? Thanks, Andrew