From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6304 invoked by alias); 6 Nov 2012 19:02:43 -0000 Received: (qmail 6291 invoked by uid 22791); 6 Nov 2012 19:02:42 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Nov 2012 19:02:26 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA6J2LIs022808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 6 Nov 2012 14:02:21 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qA6J2JH0010111; Tue, 6 Nov 2012 14:02:20 -0500 Message-ID: <50995EBB.6070503@redhat.com> Date: Tue, 06 Nov 2012 19:02:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Pierre Muller CC: devans@sourceware.org, gdb-patches@sourceware.org Subject: Re: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012 References: <20121106015848.GA5296@sourceware.org> <5098efb2.05fd440a.7696.ffffd821SMTPIN_ADDED@mx.google.com> In-Reply-To: <5098efb2.05fd440a.7696.ffffd821SMTPIN_ADDED@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00125.txt.bz2 On 11/06/2012 11:08 AM, Pierre Muller wrote: >> 281a282,283 >>> gdb/dwarf2read.c:8612: regression: xasprintf: Do not use xasprintf(), >> instead use xstrprintf >> gdb/dwarf2read.c:8612: xasprintf (&virtual_dwo_name, ', >>> gdb/dwarf2read.c:8984: regression: xasprintf: Do not use xasprintf(), >> instead use xstrprintf >> gdb/dwarf2read.c:8984: xasprintf (&dwp_name, ', dwarf2_per_objfile- >>> objfile->name); > > Doug, > > could you check the patch below > which removes the new ARI warnings about use of > xasprintf function in the commit > > http://sourceware.org/ml/gdb-cvs/2012-11/msg00027.html Déjà vu :-) http://sourceware.org/ml/gdb-patches/2009-03/msg00576.html This removes the last use of xasprintf in the tree; we should delete it to avoid new uses creeping in. -- Pedro Alves