Re: [PATCH] Display full file path in MI style disassembly listing

Jan Kratochvil
2012-10-18T13:45:22Z

On Thu, 18 Oct 2012 11:48:56 +0200, Andrew Burgess wrote:
> I took a look at the original patch. I it changes one place (in
> backtrace) where we display symtab->filename. There are several places
> where we display symtab->filename, including the one I changed.
>
> Either, (a) we plan to merge the original patch almost as is, in which
> case it only changes the backtrace code, leaving my patch free to be
> applied, or (b) we plan to extend the original patch to cover more/all
> of the places we display symtab->filename, in which case, we'd have to
> consider each of those places in turn and make a suitable change.

(b) but this seems to be irrelevant to this patch now.

> Jan, if I post a patch that adds a fullpath would you be happy with that
> as a solution?

Pedro IIUC has shown that if anywhere in MI is missing the "fullname" field
you can add it, so far there is no need to change the content of "file" field
for the MI purposes. I support this Pedro's proposal.

Thanks,
Jan