Re: Add fullname field in disassembly output

Eli Zaretskii
2012-11-03T07:42:12Z

> Date: Fri, 2 Nov 2012 10:59:17 +0000
> From: "Andrew Burgess" <aburgess@broadcom.com>
> cc: "Pedro Alves" <palves@redhat.com>
>
> On 31/10/2012 2:53 PM, Pedro Alves wrote:
>
> >> Ok to commit?
> >
> > Not yet, sorry. This new field needs to be documented in the manual, and mentioned in NEWS.
>
> Sorry, I should have realised I'd need to do these things.
>
> Latest version of patch, includes fullname field, test
> updates, noted in documentation and in NEWS file.

Thanks.

> + ** The data-disassemble command response will include a "fullname" field
> + containing the full path to the source file when gdb can determine the
> + full path, and source has been requested in the output.

Please use "absolute file name" or just "file name" instead of
"path". GNU coding standards frown upon use of "path" for anything
except PATH-style directory lists.

> -file="/kwikemart/marge/ezannoni/flathead-dev/devo/gdb/ \
> - testsuite/gdb.mi/basics.c",line_asm_insn=[
> +file="../../../src/gdb/testsuite/gdb.mi/basics.c",
> +fullname="/absolute/path/to/src/gdb/testsuite/ \
> +gdb.mi/basics.c",line_asm_insn=[

It would be better not to break the last line in the middle of a file
name, as that could confuse the reader into thinking that there's a
blank in the middle.

> -file="/kwikemart/marge/ezannoni/flathead-dev/devo/gdb/ \
> - testsuite/gdb.mi/basics.c",line_asm_insn=[
> +file="../../../src/gdb/testsuite/gdb.mi/basics.c",
> +fullname="/absolute/path/to/src/gdb/testsuite/ \
> +gdb.mi/basics.c",line_asm_insn=[

Same here.

The documentation parts are OK with those changes.