Re: Add fullname field in disassembly output

Andrew Burgess
2012-11-07T15:08:37Z

On 06/11/2012 5:44 PM, Eli Zaretskii wrote:
>> Date: Tue, 6 Nov 2012 12:13:36 +0000
>> From: "Andrew Burgess" <aburgess@broadcom.com>
>> cc: gdb-patches@sourceware.org, "Eli Zaretskii" <eliz@gnu.org>
>>
>
> The patch for the manual is OK with these changes.

Thanks for the review, I'll make those changes.

>
>> +file="../../../src/gdb/testsuite/gdb.mi/basics.c",
>> +fullname="/absolute/path/to/src/gdb/testsuite/gdb.mi/basics.c",
>> +line_asm_insn=[@{address="0x000107bc",
>> +func-name="main",offset="0",inst="save %sp, -112, %sp"@}]@},
>> src_and_asm_line=@{line="32",
>> -file="/kwikemart/marge/ezannoni/flathead-dev/devo/gdb/ \
>> - testsuite/gdb.mi/basics.c",line_asm_insn=[
>> -@{address="0x000107c0",func-name="main",offset="4",
>> -inst="mov 2, %o0"@},
>> +file="../../../src/gdb/testsuite/gdb.mi/basics.c",
>> +fullname="/absolute/path/to/src/gdb/testsuite/gdb.mi/basics.c",
>> +line_asm_insn=[@{address="0x000107c0",
>> +func-name="main",offset="4",inst="mov 2, %o0"@},
>> @{address="0x000107c4",func-name="main",offset="8",
>> inst="sethi %hi(0x11800), %o2"@}]@}]
>> (gdb)
>
> Why do we sometimes use names with a hyphen, like func-name, and
> sometimes with underscores, like line_asm_insn? Shouldn't we pick one
> and use it consistently?

That would probably be a good thing, but given I didn't add the code I'd
rather not start changing these things. Also, given that this exists in
the wild and the MI interface is supposed to remain consistent I suspect
we're stuck with what we have...

Just so I'm clear, should I consider this a block to committing this patch?

Thanks,
Andrew