From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 8334C385BF83 for ; Mon, 6 Apr 2020 18:49:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8334C385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1586198966; bh=K+KnwmrR/6+teidL31aTU8ujV6u3ex+YsFpL1KBZTAQ=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=WJ4ZflnIATsiNDaBAZvpe/77Razr/cxm0VoY+mn4/1bwhzowbluynhf54uQnGO82y SUh+l+re80lGgSJNG6U0xVNpbdL7ErDiEW3KNGTcYV3KHuwtwRcPqA17tTVcVTOiuw s2iP3PTjnW7Nw8eLcO4Xrxxg/RlH6PqzCBMovrlA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MSKyI-1jjcCL3uNE-00Sj5V; Mon, 06 Apr 2020 20:49:26 +0200 Subject: Re: [pushed] Fix build breakage in NetBSD tdep files To: Tom Tromey , gdb-patches@sourceware.org References: <20200406184343.20504-1-tromey@adacore.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <50986ea7-b10d-9405-57e2-6bf0321f8ae7@gmx.com> Date: Mon, 6 Apr 2020 20:48:14 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200406184343.20504-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:O7AeVYPfbqIABVBHg8KnFbOEfpl2mYZSqhg+hQVm5u3uiEx/eEV mgPd3pWBBz8ZKzmeN45Dfal/KQz1gIM4LQG40/rQRQbJ/6bmI/ubWtX2XUF3Lw8t1vRYJ/D 0dUyXY7or1PDYevXJLMlMS0DhfS9w7u7TILG9rsruyr2PoZ3AM6VSDo2jbV3T6b30rE2gzy ls0LZSBFnUtkKy12/Ox/Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:/QMZ/vq98p4=:8LagDMg2159c/ptG3xXgpx bIZ6zO1ZFtP6VBvJ777tSL8ZWOv7z9Xb02SR/4p8sY1T3ofkXSMN0H5mL8H6uKB637ueuWsv1 yBIJlzs6A8NISQrkIkzZ5eiOGJ7vaWptOP4pWj6mzRgCBTT+zN77zKmsv5nNTevgX9uIUIcdq tPzrZ8jVAQa7NxPsHwfCw4PbMmuko4TykuLc5pu0ocdbSbcCoLRaEvembjn87rYwNAOVxUOwe 2bHECic8gStGAPW8HbRxmEkmAlsYHsWdT3fBffDqaysmy7pPvOQZWi9xHhvwU1A9i4bCNgbD3 ZYdsiRQ0EM9E1eTXsJONB/LgxhuMAKP20dHQvgF3JvARxGsvdOtusM4zx2O1i0snXcKHU49Ui uAzCy6qc8+wTrL+t11dIqy23cF5YwYsj4bzXtVk3S9/4DBSXTk9B5eF/mC1GCM9GLHsgIQ0K9 8mANt73muMeBmThqz1MJcFZiHY96jJudNeXqSezCy4uC80JJEkLcQepR4SRjF6x0zh4IRDAQ0 b7na2e1RjhKcGujJqqelh410l6V2R9527nYxowY0jcgIoii/AthwLJSp47Gak2IHBTZWWrU0n 8HS5GxgcoZDS/hhmVKuOyKCZEirQTUsXgc3dyqwZMidg8e6MzsOfjrZMLYSHqkrb6jDoeWRoe INvmSKFYPiOnm5eGPKOdP3/EG2YNZnQ9RhkHo8LObHbVrZeE4zGzGPC/peEYDx5wntYIkEQJU xOnjRn6IZPNOPemRu/1Q6AbVrkGHVNTWhv7oHOAX6dvPsRxO1huxG+n96mvMwpr03G83CXkpt kR02f9mm5RqmxXosaEsqRzqN9Ta36NoK5nqpf1dVcPci/XVnGObD8zbxiel5p8B7ogv4g+m6y m8UEjQrm/OtVtiZXUAKU145SzfParnj9BMXcz0TScG3DSIqmFrUHEseXFid2WPSBmwELnPG1O GNxIlg6u4lnnARaH4OVMO8Em/7ICkrAMWS53oOGnUTxNgt9lsMXiexgG2w5bjkhywyw30PbcF 8bNSxbH5ECWP/cFIQBNjcwLyTzTis7lA2ivL74j6Yr5XKq22Co+0EIvE70nda2jvhbjbNk4gu CzXA5FBLkUjA0BBnziCmFjQauBc627dHXef14aX5O3vSKk9r0gCYZ06glb79XcqxPeE6KkNSS hDpeUUJumYdIiK2Wk0/MXYyG1hnYL9FUm9VOdVrzjWmW3q1F43ycFJB2v8/MYS6/3+qnw= X-Spam-Status: No, score=-28.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2020 18:49:31 -0000 Thanks! I will test next time with --enable-target=3Dall. On 06.04.2020 20:43, Tom Tromey wrote: > A recent patch caused some build failures in NetBSD tdep files. I saw > this failure in my --enable-target=3Dall build. > > This patch fixes the problems. Tested by rebuilding. > I am going to check this in. > > gdb/ChangeLog > 2020-04-06 Tom Tromey > > * sh-nbsd-tdep.c: Include nbsd-tdep.h. > * ppc-nbsd-tdep.c: Include nbsd-tdep.h. > * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";". > * arm-nbsd-tdep.c: Include nbsd-tdep.h. > * hppa-nbsd-tdep.c: Include nbsd-tdep.h. > --- > gdb/ChangeLog | 8 ++++++++ > gdb/arm-nbsd-tdep.c | 1 + > gdb/hppa-nbsd-tdep.c | 1 + > gdb/mips-nbsd-tdep.c | 2 +- > gdb/ppc-nbsd-tdep.c | 3 ++- > gdb/sh-nbsd-tdep.c | 1 + > gdb/vax-nbsd-tdep.c | 1 + > 7 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/gdb/arm-nbsd-tdep.c b/gdb/arm-nbsd-tdep.c > index a6104f760b3..b1e369d41c2 100644 > --- a/gdb/arm-nbsd-tdep.c > +++ b/gdb/arm-nbsd-tdep.c > @@ -22,6 +22,7 @@ > > #include "arch/arm.h" > #include "arm-nbsd-tdep.h" > +#include "nbsd-tdep.h" > #include "arm-tdep.h" > #include "regset.h" > #include "solib-svr4.h" > diff --git a/gdb/hppa-nbsd-tdep.c b/gdb/hppa-nbsd-tdep.c > index d601aa96f3f..5309b1976fd 100644 > --- a/gdb/hppa-nbsd-tdep.c > +++ b/gdb/hppa-nbsd-tdep.c > @@ -27,6 +27,7 @@ > > #include "hppa-tdep.h" > #include "hppa-bsd-tdep.h" > +#include "nbsd-tdep.h" > #include "gdbarch.h" > > /* From . */ > diff --git a/gdb/mips-nbsd-tdep.c b/gdb/mips-nbsd-tdep.c > index 6f4d22b24fb..524990a8097 100644 > --- a/gdb/mips-nbsd-tdep.c > +++ b/gdb/mips-nbsd-tdep.c > @@ -354,7 +354,7 @@ static void > mipsnbsd_init_abi (struct gdbarch_info info, > struct gdbarch *gdbarch) > { > - nbsd_init_abi (info, gdbarch) > + nbsd_init_abi (info, gdbarch); > > set_gdbarch_iterate_over_regset_sections > (gdbarch, mipsnbsd_iterate_over_regset_sections); > diff --git a/gdb/ppc-nbsd-tdep.c b/gdb/ppc-nbsd-tdep.c > index 81492deaccd..f2cca8f5458 100644 > --- a/gdb/ppc-nbsd-tdep.c > +++ b/gdb/ppc-nbsd-tdep.c > @@ -28,7 +28,8 @@ > #include "tramp-frame.h" > > #include "ppc-tdep.h" > -#include "ppc-nbsd-tdep.h" > +#include "nbsd-tdep.h" > +#include "ppc-tdep.h" > #include "solib-svr4.h" > > /* Register offsets from . */ > diff --git a/gdb/sh-nbsd-tdep.c b/gdb/sh-nbsd-tdep.c > index 2b2a7e3fd4a..6551c47b5e1 100644 > --- a/gdb/sh-nbsd-tdep.c > +++ b/gdb/sh-nbsd-tdep.c > @@ -26,6 +26,7 @@ > #include "osabi.h" > > #include "sh-tdep.h" > +#include "nbsd-tdep.h" > #include "solib-svr4.h" > #include "gdbarch.h" > > diff --git a/gdb/vax-nbsd-tdep.c b/gdb/vax-nbsd-tdep.c > index 7630ac5ab94..40007f11660 100644 > --- a/gdb/vax-nbsd-tdep.c > +++ b/gdb/vax-nbsd-tdep.c > @@ -22,6 +22,7 @@ > #include "osabi.h" > > #include "vax-tdep.h" > +#include "nbsd-tdep.h" > #include "solib-svr4.h" > > /* NetBSD ELF. */ >