From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1786 invoked by alias); 31 Oct 2012 18:03:14 -0000 Received: (qmail 1772 invoked by uid 22791); 31 Oct 2012 18:03:11 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Oct 2012 18:03:05 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9VI31Bg010386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 31 Oct 2012 14:03:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9VI30m6008520; Wed, 31 Oct 2012 14:03:01 -0400 Message-ID: <509167D4.20007@redhat.com> Date: Wed, 31 Oct 2012 18:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: dje@google.com CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] new tracepoint downloaded MI notification. References: <1348793347-12556-1-git-send-email-yao@codesourcery.com> <1348793347-12556-3-git-send-email-yao@codesourcery.com> <20604.20455.105300.495734@ruffy2.mtv.corp.google.com> In-Reply-To: <20604.20455.105300.495734@ruffy2.mtv.corp.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00566.txt.bz2 On 10/15/2012 07:03 PM, dje@google.com wrote: > Yao Qi writes: > > Hi, > > This patch is to add a new MI notification to MI front-end when > > tracepoints are downloaded to target. > > > > gdb: > > > > 2012-09-27 Yao Qi > > > > * target.c: Include "observer.h". > > (target_download_tracepoint): New. > > * target.h (target_download_tracepoint): Remoe macro. > > Declare target_download_tracepoint. > > * mi/mi-interp.c (mi_interpreter_init): > > (mi_tracepoint_downloaded): New. > > * observer.sh (struct bp_location): Forward declaration. > > > > * NEWS: Mention it. > > > > gdb/doc: > > > > 2012-09-27 Yao Qi > > > > * observer.texi (GDB Observers): New observer > > 'tracepoint-downloaded'. > > * gdb.texinfo (GDB/MI Async Records): Document for MI notification > > "=tracepoint-downloaded". > > > > gdb/testsuite: > > > > 2012-09-27 Yao Qi > > > > * gdb.trace/mi-traceframe-changed.exp (test_tfind_remote): Adjust. > > * gdb.trace/mi-tracepoint-downloaded.exp: New. > > Hi. > It would be useful if the reason why this notification exists was specified in the code. > E.g, "This notification exists because frontends ... [fill in the blank]." Yes, indeed. I'll probably upgrade that "useful" to "required". :-) It is not clear for example, why would the frontend care about a particular tracepoint having been downloaded. I can see it wanting to know when a trace run has started from the CLI, for instance, which already implies that tracepoints have been downloaded. -- Pedro Alves