From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ssbssa@yahoo.de>
Received: from sonic301-21.consmr.mail.ir2.yahoo.com
 (sonic301-21.consmr.mail.ir2.yahoo.com [77.238.176.98])
 by sourceware.org (Postfix) with ESMTPS id 56F7538930E6
 for <gdb-patches@sourceware.org>; Wed, 29 Apr 2020 11:00:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 56F7538930E6
X-YMail-OSG: FAJ2hxYVM1kL6jqh2275lmPiWmJkdTZzg091mwZRqW7FGJ3x.tXS38w3k3FcFyP
 x5JL1U3PXWWuQS3YtXlo2GFpNoN5PGJ3MZEXksBPZ0oubBIj3fpN1xKQ9d7Fkuc1_xIFSQa5gRoT
 cpXWtF4dtjPKEPaXMRg21QULwehgRZFa2s1mXdujj65M9eGEYweH8W_QTbX2zetkl.XwBhFZ5aM8
 8cTzbUnc7V5ZBfmEVZRyacM6xrcwlUY_lYaSWJ0S4gTF63unlTh1497GJEZB.KKAkV0lgginXlkJ
 sTkHLgDTjDNse5qGQAmjcJVQcGU06AIaqPCVFKQkvthlb39WxC4Fvo1oOSQbHmxDKVGlvsAwT0Kt
 tv2723lcc9_a5dwKM6shCKLR5pSjSgiLd.5A8e9cyqga.juItdVqxM7Wv0PwW.rN.SljQhcqzz34
 QvVPQSFolGXjca0VEPPoKnWiZ5XIo08d2yzyCygYddmyKdEAZ.PFbafEIXemVvaA3Imsm4qltrcW
 bA7TO56LTzES8BQ9YFlU84bYGHeNiNUcaNGKUrdgxPJpiADfPkmlnz14r7bpmnTeoffe1VaFDRwv
 _5trdpKpvXHhHxxdutqIGY2hNF2R618gWCmz5YNNSPBJDeFh539ekfT6iZdNG6u08YSMQ3rLN4J4
 tVSjyHnR0ggxD1yhBwX1FMlJmjSbBW1pUFrwMYgMPJAViKHOeoqSYGTxHXOK2TBC6qA0LQuZGAEu
 7Y5QFwzKk1MY8jaG1wl65mNeCU8ZSiCSDp0ZSwjkRBUC1UEHk53yTHAz6jIYGBxQDzkcpZkDSpoA
 mAcazGiNKxrvb8Gy_pevMT9Iyc71J9T_SebJQv4vJ4UcL7kHhL12HrYbSIp2WcoVrRTrAKZNivc2
 7WQys79fD6destXFCezEbxryNW3SOz9ndEYOWkVWGyMarOqGNkcQlRrS8dkf6Zgk9EFEhO1v7Ddk
 Jdsc6LPmosS0_mCURelTJWEaIWMnUbGDWcewNF7MSfbTpQjdC2BlNQuaXaGc0d_EdLXzMMdMu75h
 GqPj.doQWE4VJ_dCCESU9JjXc2ZYfj5ODnTrNXJlq0Jf25fAZvR5EIJ7alSd4ZnAvn_LcpCo6PzV
 umN9BnWN49Oaq9wD5_2WJOWtRGUe0a8qLX69SbtDTPMgvUhEaLahGZHKUkcJ5nbyNBHH3WnbWjg3
 0xA95UxRDY5i52LIXkYALfsgQ15KXtjNIkewzMpM0YTVe7RKHmp7_3bAtFhDrz817fC4VkdYG1ps
 X1fsLSs.vq29oinnvJ08p73ulXvzmQZr4bBhCKjTZIZc_Q.HrDOt_e3RtQmkwg8KSXuHLYFYUakz
 JJzlBR9UvwgP0mvI-
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic301.consmr.mail.ir2.yahoo.com with HTTP; Wed, 29 Apr 2020 10:59:58 +0000
Date: Wed, 29 Apr 2020 10:59:57 +0000 (UTC)
From: Hannes Domani <ssbssa@yahoo.de>
To: Gdb-patches <gdb-patches@sourceware.org>
Message-ID: <509127707.4013029.1588157997483@mail.yahoo.com>
In-Reply-To: <86e4c9c8-77bc-00c0-526c-b2974e15d7b9@simark.ca>
References: <20200427125900.5587-1-ssbssa.ref@yahoo.de>
 <20200427125900.5587-1-ssbssa@yahoo.de>
 <86e4c9c8-77bc-00c0-526c-b2974e15d7b9@simark.ca>
Subject: Re: [PATCH v2][PR gdb/17320] Fix array pretty formatter
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Mailer: WebService/1.1.15756 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64;
 x64; rv:71.0) Gecko/20100101 Firefox/71.0
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, BODY_8BITS,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM,
 RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2020 11:00:02 -0000

 Am Dienstag, 28. April 2020, 17:17:29 MESZ hat Simon Marchi <simark@simark=
.ca> Folgendes geschrieben:

> On 2020-04-27 8:59 a.m., Hannes Domani via Gdb-patches wrote:
>
> > Currently, printing with array pretty formatting makes the output actua=
lly
> > less readable than without:
> >
> > (gdb) p -array on -- {{1,2,3},{4,5,6}}
> > $1 =3D=C2=A0 {=C2=A0=C2=A0=C2=A0 {1,
> >=C2=A0=C2=A0=C2=A0 2,
> >=C2=A0=C2=A0=C2=A0 3},
> >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {4,
> >=C2=A0=C2=A0=C2=A0 5,
> >=C2=A0=C2=A0=C2=A0 6}}
> > (gdb) p -array on -array-indexes on -- {{1,2,3},{4,5,6}}
> > $2 =3D=C2=A0 {[0] =3D=C2=A0=C2=A0=C2=A0 {[0] =3D 1,
> >=C2=A0=C2=A0=C2=A0 [1] =3D 2,
> >=C2=A0=C2=A0=C2=A0 [2] =3D 3},
> >=C2=A0 [1] =3D=C2=A0=C2=A0=C2=A0 {[0] =3D 4,
> >=C2=A0=C2=A0=C2=A0 [1] =3D 5,
> >=C2=A0=C2=A0=C2=A0 [2] =3D 6}}
> >
> > These changes now also put the first element and the array end bracket =
on a new
> > line, similar to the structure pretty formatter:
> >
> > (gdb) p -array on -- {{1,2,3},{4,5,6}}
> > $1 =3D {
> >=C2=A0 {
> >=C2=A0=C2=A0=C2=A0 1,
> >=C2=A0=C2=A0=C2=A0 2,
> >=C2=A0=C2=A0=C2=A0 3
> >=C2=A0 },
> >=C2=A0 {
> >=C2=A0=C2=A0=C2=A0 4,
> >=C2=A0=C2=A0=C2=A0 5,
> >=C2=A0=C2=A0=C2=A0 6
> >=C2=A0 }
> > }
> > (gdb) p -array on -array-indexes on -- {{1,2,3},{4,5,6}}
> > $2 =3D {
> >=C2=A0 [0] =3D {
> >=C2=A0=C2=A0=C2=A0 [0] =3D 1,
> >=C2=A0=C2=A0=C2=A0 [1] =3D 2,
> >=C2=A0=C2=A0=C2=A0 [2] =3D 3
> >=C2=A0 },
> >=C2=A0 [1] =3D {
> >=C2=A0=C2=A0=C2=A0 [0] =3D 4,
> >=C2=A0=C2=A0=C2=A0 [1] =3D 5,
> >=C2=A0=C2=A0=C2=A0 [2] =3D 6
>
> >=C2=A0 }
> > }
>
> Thanks for providing a test case, this is ok.

Pushed, thanks.


Hannes