From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22952 invoked by alias); 16 Oct 2017 22:37:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22938 invoked by uid 89); 16 Oct 2017 22:37:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 22:37:21 +0000 Received: from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 1B.71.03220.E9435E95; Tue, 17 Oct 2017 00:37:18 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.24) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 17 Oct 2017 00:37:18 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.59] (192.75.88.130) by DB4PR07MB316.eurprd07.prod.outlook.com (2a01:111:e400:982f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Mon, 16 Oct 2017 22:37:16 +0000 Subject: Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c To: Tom Tromey CC: Simon Marchi , References: <20170909153540.15008-1-tom@tromey.com> <20170909153540.15008-5-tom@tromey.com> <79955c67-567b-7bc9-c238-9245c9ab1911@ericsson.com> <6226d3be-17c7-aa69-bdbf-efe11ffc1b5f@ericsson.com> <8760bkqrf4.fsf@tromey.com> <871sm8qdm8.fsf@tromey.com> <87wp3zowki.fsf@tromey.com> From: Simon Marchi Message-ID: <508b908a-943d-e9ca-55ef-18e0dca0d7cd@ericsson.com> Date: Mon, 16 Oct 2017 22:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87wp3zowki.fsf@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR15CA0037.namprd15.prod.outlook.com (2603:10b6:300:ad::23) To DB4PR07MB316.eurprd07.prod.outlook.com (2a01:111:e400:982f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1aa32026-9a58-4fe1-c94a-08d514e67493 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB4PR07MB316; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;3:rli+dlUcaTmt3OSLU7cZPVBPJfEOsaOb89vUJ7ap+5OjGiZiPHvfOi98psMCLqAGsQiofB1+7396HDld6NofPRqqxZiH2ZYDzZsVB+kSHv5RcjHxEIptTPYGBO6xyLPzcpdGcfT+ppLJ5ohKgdzs03SoKVv6uPuL7elprytRYJiL9GLQzGrkVDiUrXA+oMNYT8Pl/AYYM28EB66w6ajxAtwFWhEqXuVZC0BwLiIzNy1qcqz4ZL4OAAwsVeepGpYI;25:BQ1VAWmaH7gpNjuq30S18zArUtqjgzjkfHRIN0GGjEBj2rnv9tBBhqaca53hYWTxqVhj0JlAnw+SQBxAKOiAdWjfg5FJMygg8soTsJugeGPbr80HMv8trM/uk5iWh1bkbiFv8MkV3dYUcGYHisKtlIE9ISurvHyzRSp2bfbQk/TIyaEKfWpyIAvDNd6SIzPWGvDivbgb7ga4ZD70XXARE11+Ak7o/wfVxRqVfZ8l2+Xp1dDKKPEkDvudzxaxuvoQBKhCZqMMU1QfZtLDOlxFV3eb8opI7gTd+sIgrNEewp9VYlish4FxS6w8h36yRvhy345CHCBQZGZI1020l3/aVW//96C3NjKUZd8+3IteCII=;31:/zMCXjgn5feP0pZOoqOzq23bOojhhwxPJJMkUF/0F5qPneYvWQMwKEVFE6hLX0p2W+WzdKX2GZLSAcpK38pNHGrTvFg78TDMJVTGOVDK4+FCPUmmu02svw/mtCjY+dTIrNfJdky/TUx6zRUOvhjrSTIcdOItFixLz+Piw4Jss0U5kWxwogawXTr+qidZPF/EA+lR4ZWQbkmpcHctJSUx245MzDks/tnqJAbj33oQicM= X-MS-TrafficTypeDiagnostic: DB4PR07MB316: X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;20:Jz3DQ4G06qioSaoiLeG7U6rnVY8o+F/3NCBL0iEysQvR4ZFDiNLh8jUWNhE8M36c9CQYX39UlcJ1eC0vSRFCuE3PXH7NhVNZYIB7hcCz+AxJ/g8SlmJGk60TzRu6MxDKLUWZxfiga/Jnj6rCa4FR6mu+3PALjNg40QuN14lWDU1xAfaHnWwua4ekMrphqmPBeNLvoyK6YxgId0GefmTKFEyqtIIbjtKKUEMzqzz89m4DxOuG25dKJQcfQL4wG19l4iU1aibkPIQqPj+c0btoP8kMC1GsULHnSutKTooDJlVi4XwjP9z30WPaPVEeAvqalXRyb3lkmaAN0jguUbRKEHKozTskYafse83UyZ4nFdMtfYuoHUypzBWJbyqt4eoZBRQCifyQFAz5XRi4PHTeH3uvJ9wUnNo0/+ktPJFQCrRpakDi2p7WXRe6ImaYB+/rPyJiwwmLwlNKrI+JwkLwoBb9xJ+1uS9xOwgWg/k0ZlMFXFM0V1OmkOfLeq3z+Nhj;4:JuE5W95PFJhdN2TgV6jhlOfc+NR0KUUsMI9i/uIu0TMGwfzpbknNU1IlHwQ7JMJOd7YvaC8PNrfpX0tHK9kZeN12JjBxeaFnyTKmuQI84B0Ha4qpcEZXHhg5wT3e8D9oUXJVaEZ5GNc2puvnTJqK/OBitVZ665jEClw3FSmDox40U8+8jCbhv3+hmYCzEfQEI18UAgavCeWxEAlE/ZMFUuEK9m7QnTxat7VsQJz7Qjk0guRsywAFKbSAljFyhzvh X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB316;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB316; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(377454003)(24454002)(189002)(377424004)(199003)(65806001)(64126003)(105586002)(54356999)(6486002)(2906002)(189998001)(16526018)(65956001)(36756003)(4001150100001)(49976008)(47776003)(23676002)(6116002)(478600001)(53936002)(53546010)(97736004)(66066001)(31686004)(50986999)(76176999)(31696002)(3846002)(305945005)(7736002)(2950100002)(6916009)(58126008)(83506001)(316002)(101416001)(16576012)(25786009)(229853002)(6246003)(33646002)(230700001)(93886005)(81166006)(68736007)(5660300001)(50466002)(4326008)(86362001)(81156014)(8676002)(6666003)(8936002)(106356001)(65826007)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB316;H:[142.133.49.59];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTY7MjM6YkFuM3N5T2hEVEtFV0JMYmY0UFZ6SWVnT0h4?= =?utf-8?B?NmlEMjExV0N5WWFMU3kwdkxHZXNMbWwyYjJoekhiZTZHTEhKa0pPN1RHZXBj?= =?utf-8?B?cWJPU0ZlTmtxSy95ZUR6RlJZdlRlR0prY3djZi9URFo1OUVEc3VBZE5wcUFO?= =?utf-8?B?cGJ0dFhkZmhwSzRiRlJ0TzJTbGtiMFVCN1BkQXJ4SnhVT3cyUHBTVjdyZGNH?= =?utf-8?B?TUFHVy9FN001VjlJTFEzVUhDTzY1WkdURmhJQU11bm4yZUdOZXgxVzRZUHhp?= =?utf-8?B?bmRRbnFxWXZYMTNpVlVOMnVpRFdIeVdlZ1lER3ppOWNjRjkzZWREd1J0bTlT?= =?utf-8?B?ZTV0b3ZtUDBGeEdnYkxvV2ZuRWkyaFBkY0toTUpmWXRpa2JvbzBOdkhzUWhX?= =?utf-8?B?UzF4cjF1TjZYRmlqeEUxZHI0OURkb05DczMzNW90dmtUMEloemdvcFR5Q3dP?= =?utf-8?B?SUttdDJEMmVwaURRUjRtZVcxTm8rdW1UVWtaV2h6VFBKOVZkb1Q2VVNDVW9R?= =?utf-8?B?ZDJuM29yeld5eXpRbjU4WXliNDd1ZUdlZ2NKRjl0VTRCeTZkaGZ0VEJTOURw?= =?utf-8?B?dWlyb1o2Smp5NWRKL0g5S3BvWFRLTmNRV2dWNEFCdWZnYkluUzNyeURCZzky?= =?utf-8?B?aEZEWGdrMzhSbjI5ZTZTemwrTEVMa0hzUDlQdTl4NjUxMEhvYjNITk5FMFJN?= =?utf-8?B?ZGtENndSQ1FLZUtDMC82eFVQVHlBYUpIdFphdEtpQktTaGl1ZklNb1ZmaVA1?= =?utf-8?B?SFd1WTB3WXFpTTBNbGhVMlVmQ0xzdWpnL1dwM0NYQVY4YnNMY2pVa1FCV2lq?= =?utf-8?B?SVpOb3pKTXRvNGRXWUNyUUlKNkNHMzd1ZmsvWmkxMWdSOHppa0FMZlZlN1RK?= =?utf-8?B?bW9PQ1VUVy9TeXVyVTlud1hkOWI2QVpRZEhqWEE2dmZnZkN5bHQ1NU1IMUhR?= =?utf-8?B?Q1pKdFI0UnJORTR6bjF6WXNONmFKOFhxb1BwRC92N1kyOXZBRU11aXREYXV3?= =?utf-8?B?L244WWE4c0hEQms3SWpnZWxDOGxSeWtYa1RKekErS2pHRENuYTBhUEE3OGhT?= =?utf-8?B?MFcvU251K0w0dklhWXRBZ3IxaU51ZzVjWVBJNW15VklpYXVDbGdiTGxXVk83?= =?utf-8?B?eFRHemJuOU0vVlA0eWxZaXlGa1ZTV2hienBSZkkvSUN5WVowU1JKRHdYNnRS?= =?utf-8?B?a3UwNHBHenk0cGM5aHZIVFBTVjFINTc4OHQybFFkcXVaUVFGWEFhZmZOYlNO?= =?utf-8?B?MmJGK0dkUXJrWS83cWd0bFBPZkFLRTBxV0VsNTR2ZmtFV0JEQWJTcERDOFRC?= =?utf-8?B?SmpHeTlrMWJCdnlHdDJ2WG81ZHlwTU1tMk9obDNzTmlsNWJ0QVNSZVNkUU1T?= =?utf-8?B?eWlsVDFpbWNHeW9HdFJReVFyQlN0TFdPQzdRUGpBaEJERmtjSm8zR0YydCtG?= =?utf-8?B?UCtuYmNwZ3NHUEVZV3J0akFlSlFlL3MvR3lnaTljWFNSWkFBS29iRGFNb1lF?= =?utf-8?B?L2ttQmNrR3c3bng4Y01xTkpMSlVVTjMxSFBXRVIza3VaL2Fxa09UVk8vQXdU?= =?utf-8?B?a253L1dCUDMreWxWd3V5VmxFQk1xWHhMa0dyT0tzejQ0eGlQK2VHWTI5cWo0?= =?utf-8?B?bkZJZS90bURveG95ZWNGTmlIY2NqNjRMOWIwdk1LdldyRTdxdmZCRlF1MzRO?= =?utf-8?B?RytrT2pobnpCbXdlVmo4aE5ackF5N2ZySzVvZUh4c29oUm5pZjFFU0M5dW9Z?= =?utf-8?B?OXRMazV1MmJlZTdoQzMyUFhORzJtZCtxTEIxbXMzM1V1Z0VuVXlSYjJiMU1E?= =?utf-8?B?MFZOUlgwaForMXIxVFBETS9sNzRvbnpKQkJPQzJ0OHZNYVJYdjluSjB1SU8r?= =?utf-8?B?clBRbk5WWEYvYmFiK2VvUWJlTE83TFdFQlljSGlVTlNJWGU1WmFVOFJvVzRq?= =?utf-8?B?UmFwOHJKVk1rSkw5SHhFNzRBV3JrTEVGdmw1STRzZVVidThlaHloS2FnU0ts?= =?utf-8?Q?2IlBR?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;6:+SaHg3XV+GovUSG7pEPPH5AErqKw1cV2mr6onojAg50Vksf7MDnuzQYXZ1e6GiSiJGYluqK7B/TceL4Y7s2qow2+919x89KljrxV04eQ50PNSlY1dzaN+b59G1FhCJHV7OAz/yQm98t4tkOKnnYeC+HvN93PM9ppbuQo34SOMfLwSROTWd/fxMeR2q3NSy1ytd1rGlNUzKGEYvudoFKJohc87uDdYOZngWc4b3/5Hv1xIWAObMR1h6KrTGPTgORQcl0OLNyzd20Fgp4Nkdjf2hd7VHXPD7cDjx3TUG3Dodl/OqHE7NLqctCUxNfsDfDEZ3WHs0/BQE/jXaPZqmb5YQ==;5:qjdTEreiPrSv8jX0SUtTw7l5tZtX627/fY83tMiFFLFTyCuriwkODK8LUAor8L1wCM8xmGF6UFoM1bIbUSXJMsokSEhiFYPQitju7zCquNQGvFo+yZPnsahLC4pIyBeXa0f0u6cA6y4tWBB6nLRiag==;24:IBxxnu0Fem9suMWmARmkEFE/ayI0UjyKPWrcOt67IIaskFYu3QDScqjoelyrRzxtnXyQlSQe6Jt+kd0QbetoXhWLTh7etmMj3Xz0WR0sNf8=;7:/xk+PY3PhANwE7P1XlJa1roEr1s1hAwLazCd2VKqG6XiVJ1MoLgGYQT/R/zS7mR+nEZR3CN5wJrBZVghjusXYW6rtVnaVAkAgYj6sJfupp8Dtjl0DvUk8oSTPpERP5LL/5VMuUhYzl6Cnodq2HC6WpS3bqHs393SSWGSIqK4/5A4RKSRIJXcBGQIDjD9r6cTSL0l7WxtM2IqsUtPIuV/M11lQZ7KIcmz1g4WGy0RCBI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 22:37:16.3044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB316 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00484.txt.bz2 On 2017-10-13 12:13 PM, Tom Tromey wrote: > Tom> It turns out that with gdb::optional, you don't have to untangle it. > Tom> I'm testing a patch to convert the rest of disasm.c away from cleanups. > > How about this? > > Tom > > commit 1b83351de30ed32808aa8b09d720556d423e57c6 > Author: Tom Tromey > Date: Thu Oct 12 15:07:35 2017 -0600 > > Remove cleanups from disasm.c > > This changes the remaining spots in disasm.c to use the RAII ui-out > emitters, removing a few cleanups. This also fixes a regression that > Simon pointed out. > > 2017-10-12 Tom Tromey > > * disasm.c (do_mixed_source_and_assembly_deprecated): Use > gdb::optional, ui_out_emit_list, ui_out_emit_tuple. > (do_mixed_source_and_assembly): Likewise. That looks good to me (though I'm a bit overwhelmed by that code). The regression I pointed out is fixed, mi-disassemble.exp passes and I manually tested with the disassembly view of Eclipse, which exercises that code. So I think it's safe enough. Thanks! Simon