From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23350 invoked by alias); 26 Oct 2012 17:40:24 -0000 Received: (qmail 23341 invoked by uid 22791); 26 Oct 2012 17:40:23 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Oct 2012 17:40:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9QHeFNW031218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Oct 2012 13:40:17 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9QHe8DF011189; Fri, 26 Oct 2012 13:40:14 -0400 Message-ID: <508ACAF8.8050804@redhat.com> Date: Fri, 26 Oct 2012 17:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: Patch: fix catch syscall completion References: <87fw512ls8.fsf@fleche.redhat.com> In-Reply-To: <87fw512ls8.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00520.txt.bz2 On 10/26/2012 06:19 PM, Tom Tromey wrote: > I noticed that the "catch syscall" completer doesn't work quite right. > It will complete "catch syscall vfor" ok, but not a multi-word > use like "catch syscall read vfor". > > This patch fixes the bug. New test case included. > Built and regtested on x86-64 Fedora 16. Looks OK to me. > 2012-10-26 Tom Tromey > > * breakpoint.c (catch_syscall_completer): Pass 'word' as second > argument to complete_on_enum. > > 2012-10-26 Tom Tromey > > * gdb.base/catch-syscall.exp (do_syscall_tests): Add completion > test. -- Pedro Alves