From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31816 invoked by alias); 25 Oct 2012 14:55:07 -0000 Received: (qmail 31803 invoked by uid 22791); 25 Oct 2012 14:55:06 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Oct 2012 14:54:56 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TROpi-0001aS-Ez from Yao_Qi@mentor.com ; Thu, 25 Oct 2012 07:54:54 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 25 Oct 2012 07:54:54 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Thu, 25 Oct 2012 07:54:53 -0700 Message-ID: <508952B9.4020908@codesourcery.com> Date: Thu, 25 Oct 2012 14:55:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH] Fix kfail in gdb.base/callfuncs.exp References: <1350301607-16574-1-git-send-email-yao@codesourcery.com> <877gqhf2uk.fsf@fleche.redhat.com> <50879C02.4040106@codesourcery.com> <87k3ufapgs.fsf@fleche.redhat.com> In-Reply-To: <87k3ufapgs.fsf@fleche.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00496.txt.bz2 On 10/24/2012 10:56 PM, Tom Tromey wrote: > Yao> The patch below is to replace 'setup_kfail_for_target' with > Yao> 'setup_kfail', and add one sentence of comment to proc > Yao> 'setup_kfail_for_target'. Is it OK? > > Looks good to me, thanks. When I prepare to commit this patch today, I find that Mark committed this patch, which makes setup_kfail_for_target useless, because we don't have to link the same fail to different PRs. Re: [PATCH] PR gdb/12776 is now fixed as well; adjust testsuite http://sourceware.org/ml/gdb-patches/2012-10/msg00491.html As we discussed above, I remove proc 'setup_kfail_for_target' in this patch together. Committed as the delta part is obvious. -- Yao 2012-10-25 Yao Qi * gdb.trace/ftrace.exp (test_fast_tracepoints): Use 'setup_kfail' instead of 'setup_kfail_for_target'. * gdb.base/varargs.exp: Likewise. * lib/gdb.exp (setup_kfail_for_target): Remove. Index: testsuite/gdb.base/varargs.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/varargs.exp,v retrieving revision 1.21 diff -u -r1.21 varargs.exp --- testsuite/gdb.base/varargs.exp 25 Oct 2012 08:59:07 -0000 1.21 +++ testsuite/gdb.base/varargs.exp 25 Oct 2012 13:00:30 -0000 @@ -116,15 +116,15 @@ global gdb_prompt set test "print find_max_float_real(4, fc1, fc2, fc3, fc4)" - setup_kfail_for_target gdb/12791 "arm*-*-*" + setup_kfail gdb/12791 "arm*-*-*" gdb_test $test ".*= 4 \\+ 4 \\* I" $test set test "print find_max_double_real(4, dc1, dc2, dc3, dc4)" - setup_kfail_for_target gdb/12791 "arm*-*-*" + setup_kfail gdb/12791 "arm*-*-*" gdb_test $test ".*= 4 \\+ 4 \\* I" $test set test "print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4)" - setup_kfail_for_target gdb/12791 "arm*-*-*" + setup_kfail gdb/12791 "arm*-*-*" gdb_test $test ".*= 4 \\+ 4 \\* I" $test } Index: testsuite/gdb.trace/ftrace.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.trace/ftrace.exp,v retrieving revision 1.6 diff -u -r1.6 ftrace.exp --- testsuite/gdb.trace/ftrace.exp 26 Jun 2012 18:25:19 -0000 1.6 +++ testsuite/gdb.trace/ftrace.exp 25 Oct 2012 13:00:49 -0000 @@ -132,13 +132,13 @@ gdb_test "tfind pc *set_point" "Found trace frame .*" \ "tfind set_point frame, first time" - setup_kfail_for_target "gdb/13808" "x86_64-*-linux*" + setup_kfail "gdb/13808" "x86_64-*-linux*" gdb_test "print globvar" " = 1" gdb_test "tfind pc *set_point" "Found trace frame .*" \ "tfind set_point frame, second time" - setup_kfail_for_target "gdb/13808" "x86_64-*-linux*" + setup_kfail "gdb/13808" "x86_64-*-linux*" gdb_test "print anarg" " = 200" gdb_test "tfind start" "Found trace frame .*" \ cvs diff: Diffing testsuite/gdb.xml cvs diff: Diffing testsuite/lib Index: testsuite/lib/gdb.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v retrieving revision 1.220 diff -u -r1.220 gdb.exp --- testsuite/lib/gdb.exp 15 Oct 2012 17:35:54 -0000 1.220 +++ testsuite/lib/gdb.exp 25 Oct 2012 13:01:22 -0000 @@ -3434,14 +3434,6 @@ return $ret; } -# Like setup_kfail, but only call setup_kfail conditionally if -# istarget[TARGET] returns true. -proc setup_kfail_for_target { PR target } { - if { [istarget $target] } { - setup_kfail $PR $target - } -} - # gdb_get_line_number TEXT [FILE] # # Search the source file FILE, and return the line number of the