Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Really release IPC resources in info-os.exp
Date: Tue, 23 Oct 2012 15:47:00 -0000	[thread overview]
Message-ID: <5086BC12.5070103@codesourcery.com> (raw)
In-Reply-To: <20121023141353.GB3555@adacore.com>

On 10/23/2012 10:13 PM, Joel Brobecker wrote:
>> 2012-10-23  Yao Qi  <yao@codesourcery.com>
>>
>> 	* gdb.base/info-os.exp: Resume the inferior until it exits.
> 
> Regardless of your problem, any change that removes a call to send_gdb
> and uses gdb_test instead is a good change in my books. So OK to commit.
> 
> IIRC, you don't need the leading ".*", which is implicit, but it might
> be clearer the way you have it.
> 

This is what I committed, with leading ".*" removed.

-- 
Yao

gdb/testsuite:

2012-10-23  Yao Qi  <yao@codesourcery.com>

	* gdb.base/info-os.exp: Resume the inferior until it exits.
---
 gdb/testsuite/gdb.base/info-os.exp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdb/testsuite/gdb.base/info-os.exp b/gdb/testsuite/gdb.base/info-os.exp
index 541f03b..45f3103 100644
--- a/gdb/testsuite/gdb.base/info-os.exp
+++ b/gdb/testsuite/gdb.base/info-os.exp
@@ -176,4 +176,4 @@ expect_multiline "info os msg" "$msgkey +$msqid +666 .*" "get message queues"
 # The SysV IPC primitives linger on after the creating process is killed
 # unless they are destroyed explicitly, so allow the test program to tidy
 # up after itself.
-send_gdb "continue\n"
+gdb_test "continue" "exited.*"
-- 
1.7.7.6



      reply	other threads:[~2012-10-23 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23  3:25 Yao Qi
2012-10-23 14:14 ` Joel Brobecker
2012-10-23 15:47   ` Yao Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5086BC12.5070103@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox