From: Pedro Alves <palves@redhat.com>
To: Giuseppe MONTALTO <giuseppe.montalto@st.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
"tromey@redhat.com" <tromey@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Hafiz_Abid@mentor.com" <Hafiz_Abid@mentor.com>
Subject: Re: [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions)
Date: Fri, 19 Oct 2012 16:56:00 -0000 [thread overview]
Message-ID: <50818617.1040306@redhat.com> (raw)
In-Reply-To: <76FE3225DF13124EA2D05B290B624C95E66C43ADB1@SAFEX1MAIL1.st.com>
On 10/19/2012 03:11 PM, Giuseppe MONTALTO wrote:
> + * gdb.texinfo (-data-write-memory-bytes): Changed the command
> + description and added an example to reflect current implementation.
Don't use past tense:
s/Changed/Change/
s/added/add/
The norm is to use the section name as context. As with the other log entry, I'd
mention exactly what is being changed to help archaeology/grepping. Thus I suggest:
* gdb.texinfo (GDB/MI Data Manipulation): Document new optional parameter
"count" of -data-write-memory-bytes, and add an example.
Thanks.
--
Pedro Alves
next prev parent reply other threads:[~2012-10-19 16:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 16:18 [PATCH] new MI command for pattern filling of memory regions Giuseppe MONTALTO
2012-05-09 16:30 ` Tom Tromey
2012-05-09 18:11 ` Tom Tromey
2012-05-10 11:41 ` Giuseppe MONTALTO
2012-05-10 13:57 ` Tom Tromey
2012-05-11 8:53 ` Giuseppe MONTALTO
2012-05-11 14:36 ` Tom Tromey
2012-05-11 16:06 ` Giuseppe MONTALTO
2012-05-25 14:35 ` Giuseppe MONTALTO
2012-06-12 9:07 ` Giuseppe MONTALTO
2012-06-12 10:01 ` Abid, Hafiz
2012-06-12 14:13 ` Giuseppe MONTALTO
2012-06-12 14:22 ` [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions) Giuseppe MONTALTO
2012-09-14 16:30 ` Tom Tromey
2012-09-18 15:19 ` Giuseppe MONTALTO
2012-09-26 20:44 ` Tom Tromey
2012-09-27 15:27 ` Giuseppe MONTALTO
2012-09-28 20:07 ` Tom Tromey
2012-10-01 9:29 ` Giuseppe MONTALTO
2012-10-17 20:59 ` Tom Tromey
2012-10-18 13:40 ` Giuseppe MONTALTO
2012-10-18 15:41 ` Pedro Alves
2012-10-18 16:16 ` Giuseppe MONTALTO
2012-10-18 16:28 ` [+docs] " Pedro Alves
2012-10-18 17:31 ` Eli Zaretskii
2012-10-18 17:30 ` Eli Zaretskii
2012-10-19 14:12 ` Giuseppe MONTALTO
2012-10-19 16:34 ` Eli Zaretskii
2012-10-19 16:56 ` Pedro Alves [this message]
2012-10-22 7:02 ` Giuseppe MONTALTO
2012-11-08 20:37 ` Tom Tromey
2012-11-09 8:59 ` Giuseppe MONTALTO
2012-11-12 16:52 ` Tom Tromey
2012-11-13 10:50 ` Giuseppe MONTALTO
2012-11-13 21:19 ` Tom Tromey
2012-10-18 16:38 ` Giuseppe MONTALTO
2012-10-18 19:45 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50818617.1040306@redhat.com \
--to=palves@redhat.com \
--cc=Hafiz_Abid@mentor.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=giuseppe.montalto@st.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox