From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 876 invoked by alias); 18 Oct 2012 15:41:00 -0000 Received: (qmail 857 invoked by uid 22791); 18 Oct 2012 15:40:58 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Oct 2012 15:40:52 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IFeoSA026658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 18 Oct 2012 11:40:51 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9IFemlp025043; Thu, 18 Oct 2012 11:40:49 -0400 Message-ID: <50802300.6040304@redhat.com> Date: Thu, 18 Oct 2012 15:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: Giuseppe MONTALTO CC: Tom Tromey , "gdb-patches@sourceware.org" , "Abid, Hafiz" Subject: Re: [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions) References: <76FE3225DF13124EA2D05B290B624C95E65F2D466E@SAFEX1MAIL1.st.com> <87sjf9rzr0.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E65FECE356@SAFEX1MAIL1.st.com> <871umsqgu8.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E65FECE48F@SAFEX1MAIL1.st.com> <87397624b9.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E662A6921F@SAFEX1MAIL1.st.com> <76FE3225DF13124EA2D05B290B624C95E6632A4256@SAFEX1MAIL1.st.com> <878vcc1s9f.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E66B003EA8@SAFEX1MAIL1.st.com> <87wqzgwm4k.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E66B004AC6@SAFEX1MAIL1.st.com> In-Reply-To: <76FE3225DF13124EA2D05B290B624C95E66B004AC6@SAFEX1MAIL1.st.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00327.txt.bz2 On 09/27/2012 04:26 PM, Giuseppe MONTALTO wrote: > +++ b/gdb/testsuite/gdb.mi/mi-fill-memory.exp > @@ -0,0 +1,68 @@ > +# Copyright (C) 2012 Free Software Foundation, Inc. > +# Copyright (C) 2012 STMicroelectronics Sorry, this is not OK. In order to accept it, the copyright needs to be assigned to the FSF, only. While at it: > + > + * mi/mi-main.c (mi_cmd_data_write_memory): Additional ^^ single space here. > + parameter for pattern filling of memory regions ^ Missing period. I'd mention COUNT explicitly, to help grepping. Thus: * mi/mi-main.c (mi_cmd_data_write_memory): Handle additional parameter COUNT, for pattern filling of memory regions. > +if {[build_executable ${testfile}.exp ${binfile} ${srcfile}.c {debug additional_flags=-DFAKEARGV}] == -1} { This FAKEARGV usage looks like an unnecessary copy&paste. Please remove it. It was removed from mi-read-memory.exp too on 2012-07-10. > +# test basic Machine interface (MI) operations > +# > +# Verify that, using the MI, we can load a program and do > +# other basic things that are used by all test files through mi_gdb_exit, > +# mi_gdb_start, mi_delete_breakpoints, mi_gdb_reinitialize_dir and > +# mi_gdb_load, so we can safely use those. > +# > +# The goal is not to test gdb functionality, which is done by other tests, > +# but the command syntax and correct output response to MI operations. > +# All this text too. I see that it's been blindly copied to a _lot_ of files.. :-/ -- Pedro Alves