From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31240 invoked by alias); 18 Oct 2012 10:17:33 -0000 Received: (qmail 31231 invoked by uid 22791); 18 Oct 2012 10:17:32 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Oct 2012 10:17:26 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IAHOTs024303 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 18 Oct 2012 06:17:25 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9IAHNZh032167; Thu, 18 Oct 2012 06:17:23 -0400 Message-ID: <507FD732.8010400@redhat.com> Date: Thu, 18 Oct 2012 10:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: Andrew Burgess CC: Jan Kratochvil , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Display full file path in MI style disassembly listing References: <506DB4B8.5030001@broadcom.com> <20121005124353.GA22997@host2.jankratochvil.net> <507EF554.4080404@redhat.com> <20121018064825.GA15668@host2.jankratochvil.net> <507FD088.4030101@broadcom.com> In-Reply-To: <507FD088.4030101@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00320.txt.bz2 On 10/18/2012 10:48 AM, Andrew Burgess wrote: >>> I think we should >>> output a "fullname" field for MI, like we do for breakpoints. > > I would be happy to take this approach as a compromise. IMO, it's not really a compromise. It's all about giving all the data to the frontend, so it can do whatever it pleases. - the file path as recorded in the compilation. This is useful to have so the user can identify issues with fullpath mappings. - the file path gdb thinks that maps to in the filesystem, using the current settings of "directory/set directories/etc". I'd even argue that the backtrace path in question should not change the "file" field in MI, but instead it would add a new field to the output, if that's also useful for MI. -- Pedro Alves