From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20159 invoked by alias); 17 Oct 2012 16:35:08 -0000 Received: (qmail 19919 invoked by uid 22791); 17 Oct 2012 16:35:06 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Oct 2012 16:35:01 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HGZ0np009704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Oct 2012 12:35:00 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9HGYwgC007956; Wed, 17 Oct 2012 12:34:59 -0400 Message-ID: <507EDE32.3050105@redhat.com> Date: Wed, 17 Oct 2012 16:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: Tom Tromey CC: Sanjoy Das , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface. References: <1349696849-9056-1-git-send-email-sanjoy@playingwithpointers.com> <1349696849-9056-4-git-send-email-sanjoy@playingwithpointers.com> <871ugy896w.fsf@fleche.redhat.com> <507ED9B1.8070201@redhat.com> <87r4ox3vyv.fsf@fleche.redhat.com> In-Reply-To: <87r4ox3vyv.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00281.txt.bz2 On 10/17/2012 05:27 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> This means that shlib tests are never skipped on native, but > Pedro> it doesn't prevent it from running elsewhere. > > Oh, duh. > Sanjoy, your test has to check isnative. > > Pedro> Should the test be native-only? If so, why? Doesn't the jit > Pedro> interface work when debugging with remote targets (e.g., > Pedro> gdbserver)? > > It does, but this tests the 'jit-reader-load' functionality, which means > it must build a .so that gdb itself loads. 'isnative' isn't maybe > exactly the right test -- you might have a build-x-host toolchain -- but > it seems simplest. Ah, I see. We're talking about different "native's". Dejagnu's isnative only compares host vs target triplets. Indeed that sounds simplest. Bailing if !isnative will still run the tests if testing with a gdbserver of the triplet as the host (of which native gdbserver testing is a special case), so I'm happy with that. (We should still add a gdb_load_shlibs call.) -- Pedro Alves