From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9538 invoked by alias); 16 Oct 2012 14:59:54 -0000 Received: (qmail 9528 invoked by uid 22791); 16 Oct 2012 14:59:52 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Oct 2012 14:59:47 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TO8cT-0004Rw-Qg from Dmitry_Kozlov@mentor.com ; Tue, 16 Oct 2012 07:59:45 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 16 Oct 2012 07:59:45 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.1.289.1; Tue, 16 Oct 2012 15:59:35 +0100 Message-ID: <507D7654.90206@mentor.com> Date: Tue, 16 Oct 2012 14:59:00 -0000 From: Dmitry Kozlov User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Tom Tromey CC: , "'Stan_Shebs@mentor.com'" , Vladimir Prus , Pedro Alves Subject: Re: PATCH fix start-time and stop-time in trace-status References: <506444DD.9040503@mentor.com> <87d317wlaa.fsf@fleche.redhat.com> <50699D74.2090401@mentor.com> <87mwzna6u3.fsf@fleche.redhat.com> In-Reply-To: <87mwzna6u3.fsf@fleche.redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00251.txt.bz2 Hi Tom, Pedro already asked to rewrite this patch at gdbserver-side and use hex instead of decimal. See http://sourceware.org/ml/gdb-patches/2012-10/msg00193.html Could you setup one common opinion about what way is right? It would very kind of you if you can look at other 2 related patches. Thank you, Dmitry On 10/15/2012 11:11 PM, Tom Tromey wrote: >>>>>> "Dmitry" == Dmitry Kozlov writes: > Dmitry> +2012-10-01 Dmitry Kozlov > Dmitry> + > Dmitry> + * tracepoint.c (trace_status_command): Fix type of printf arg. > Dmitry> + (trace_status_mi): Likewise. > > Looks pretty good. > > Dmitry> + val = strtoulst(++p1, (const char **) &p, 10); > > Space before open paren. > > Dmitry> + val = strtoulst(++p1, (const char **) &p, 10); > > Likewise. > > This is ok with these fixed. > > Tom