Hi Yao, thank you for review, here is revised patch. Dmitry On 10/11/2012 04:10 AM, Yao Qi wrote: > On 10/10/2012 07:17 PM, Dmitry Kozlov wrote: >> + if (ts->stop_desc) >> + { >> + char *buf = (char *) xmalloc (strlen (ts->stop_desc) * 2 + 1); >> + >> + bin2hex ((gdb_byte *) ts->stop_desc, buf, 0); >> + fprintf (fp, ";stop-notes:%s", buf); >> + } > > Besides Stan's comments, the indentation here looks strange to me, and > BUF is not xfree'ed. >