From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20505 invoked by alias); 10 Oct 2012 15:47:57 -0000 Received: (qmail 20490 invoked by uid 22791); 10 Oct 2012 15:47:54 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Oct 2012 15:47:42 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TLyVZ-00022B-DG from Dmitry_Kozlov@mentor.com for gdb-patches@sourceware.org; Wed, 10 Oct 2012 08:47:41 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 10 Oct 2012 08:47:41 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 10 Oct 2012 16:47:39 +0100 Message-ID: <50759897.7060104@mentor.com> Date: Wed, 10 Oct 2012 15:47:00 -0000 From: Dmitry Kozlov User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: "Abid, Hafiz" CC: "gdb-patches@sourceware.org" , "Shebs, Stan" , "Prus, Vladimir" , "Qi, Yao" Subject: Re: [PATCH] Modify trace-status output to always output stop-notes. References: <50755958.5090107@mentor.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00161.txt.bz2 Hi Abid, thank you for noting this, I will repost patch with this change after collecting other's comments. Regards, Dmitry On 10/10/2012 04:40 PM, Abid, Hafiz wrote: > Just a small formatting nit. > + else if (strncmp (p, "stop-notes", p1 - p) == 0) > + { > + ++p1; > + ts->stop_desc= xmalloc (strlen (p) / 2); > A space is missing before = > + end = hex2bin (p1, ts->stop_desc, (p3 - p1) / 2); > + ts->stop_desc[end] = '\0'; > + p = p3; > + } > > Regards, > Abid > -- > Hafiz Abid Qadeer > Mentor Graphics > hafiz_abid@mentor.com > +44 161 926 1630 > >> -----Original Message----- >> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> owner@sourceware.org] On Behalf Of Kozlov, Dmitry >> Sent: Wednesday, October 10, 2012 12:18 PM >> To: gdb-patches@sourceware.org; Shebs, Stan >> Cc: Prus, Vladimir; Qi, Yao >> Subject: [PATCH] Modify trace-status output to always output stop- >> notes. >> >> Hi, >> accoriding to discussion in gdb mailing list I have added stop-notes as >> mandatory part of MI trace-status command. This makes processing of >> stop-notes on IDE side more uniform with trace-notes processing. >> Previously Yao mentioned that he implemented notifications that can be >> used to monitor trace-status, but putting stop-notes to trace-status >> looks more clear way because processing one extra trace-status >> parameter defferently from others. >> >> Stan, is it ok? >> >> Thank you