From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5228 invoked by alias); 8 Oct 2012 12:48:11 -0000 Received: (qmail 5207 invoked by uid 22791); 8 Oct 2012 12:48:08 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Oct 2012 12:48:02 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TLCkc-0004LW-3n from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 08 Oct 2012 05:48:02 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 8 Oct 2012 05:48:02 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Mon, 8 Oct 2012 05:48:00 -0700 Message-ID: <5072CB78.8030908@codesourcery.com> Date: Mon, 08 Oct 2012 12:48:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Dmitry Kozlov CC: , "'Stan_Shebs@mentor.com'" , Vladimir Prus Subject: Re: [PATCH] Extend tsave: save start time, stop time, user and notes References: <506C4719.3030900@mentor.com> In-Reply-To: <506C4719.3030900@mentor.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00130.txt.bz2 On 10/03/2012 10:09 PM, Dmitry Kozlov wrote: In general, I think it is useful to include these attributes in tracefile saved by command 'tsave'. > 2012-10-03 Dmitry Kozlov > > * tracepoint.c (trace_save): Add saving starttime, stoptime, user and notes. > > diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c > index 0f94150..f7e96eb 100644 > --- a/gdb/tracepoint.c > +++ b/gdb/tracepoint.c > @@ -3036,6 +3036,24 @@ trace_save (const char *filename, int target_does_save) > fprintf (fp, ";disconn:%x", ts->disconnected_tracing); > if (ts->circular_buffer) > fprintf (fp, ";circular:%x", ts->circular_buffer); > + if (ts->start_time) > + fprintf (fp, ";starttime:%ld%06ld", (long int) (ts->start_time / 1000000), (long int) (ts->start_time % 1000000)); This line is too long... > + if (ts->stop_time) > + fprintf (fp, ";stoptime:%ld%06ld", (long int) (ts->stop_time / 1000000), (long int) (ts->stop_time % 1000000)); and this line. > + if (ts->notes) ts->notes will never be NULL, because GDBserver will always send "notes:" in qTStatus packet (See gdbserver/tracepoint.c:cmd_qtstatus), but other stubs may don't include "notes:" in qTStatus packet, so we may do the check here like this, if (ts->notes && ts->notes[0] != 0) > + { > + char *buf = (char *) alloca (strlen (ts->notes) * 2 + 1); We need a blank line here. Looks 'alloca' is not encouraged to use, and it should be replaced with xmalloc/xfree. [PATCH] Replace potentially unsafe alloca with xmalloc/xfree in value_concat http://sourceware.org/ml/gdb-patches/2012-09/msg00274.html > + bin2hex ((gdb_byte *) ts->notes, buf, 0); > + fprintf (fp, ";notes:%s", buf); > + > + } > + if (ts->user_name) > + { > + char *buf = (char *) alloca (strlen (ts->user_name) * 2 + 1); Likewise. > + bin2hex ((gdb_byte *) ts->user_name, buf, 0); > + fprintf (fp, ";username:%s", buf); > + > + } > fprintf (fp, "\n"); > > /* Note that we want to upload tracepoints and save those, rather Logically, this patch depends on your previous patch PATCH fix start-time and stop-time in trace-status http://sourceware.org/ml/gdb-patches/2012-09/msg00621.html otherwise, we generate start-time and stop-time in trace file in decimal format, while gdb still interprets it as hex. -- Yao