From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22989 invoked by alias); 8 Oct 2012 11:47:06 -0000 Received: (qmail 22977 invoked by uid 22791); 8 Oct 2012 11:47:04 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Oct 2012 11:46:59 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TLBnW-0006HC-OP from Ali_Anwar@mentor.com for gdb-patches@sourceware.org; Mon, 08 Oct 2012 04:46:58 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 8 Oct 2012 04:46:58 -0700 Received: from [137.202.157.121] (147.34.91.1) by SVR-ORW-FEM-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server (TLS) id 14.1.289.1; Mon, 8 Oct 2012 04:47:02 -0700 Message-ID: <5072BCA5.7020001@codesourcery.com> Date: Mon, 08 Oct 2012 11:47:00 -0000 From: ali_anwar User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: Yao Qi CC: Subject: Re: "maint print arch" causing gdb crash References: <506EEAEC.2010604@codesourcery.com> <50714659.6060807@codesourcery.com> In-Reply-To: <50714659.6060807@codesourcery.com> Content-Type: multipart/mixed; boundary="------------000305030700060907010300" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00128.txt.bz2 --------------000305030700060907010300 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 876 On 10/07/2012 02:07 PM, Yao Qi wrote: > On 10/05/2012 10:13 PM, ali_anwar wrote: > >> Index: ChangeLog >> =================================================================== >> RCS file: /cvs/src/src/ChangeLog,v > > Hi, Ali, > You should record your change in src/gdb/ChangLog instead of the > top-level one (src/ChangLog). > Thanks Yao. Please find attached the updated patch. Please also note that its my first patch for gdb. I might not have the commit rights. What you suggest should I do under such circumstances? >> retrieving revision 1.1037 >> diff -u -r1.1037 ChangeLog >> --- ChangeLog 29 Sep 2012 15:35:50 -0000 1.1037 >> +++ ChangeLog 5 Oct 2012 12:48:14 -0000 >> @@ -1,3 +1,10 @@ >> +2012-10-05 Ali Anwar >> + >> + gdb/ > ^^^^ it is not needed since we put changelog entry to src/gdb/ChangeLog. Also removed "gdb/". Thanks, -Ali --------------000305030700060907010300 Content-Type: text/x-patch; name="gdb_crash.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gdb_crash.patch" Content-length: 6405 Index: gdb/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.14728 diff -u -r1.14728 ChangeLog --- gdb/ChangeLog 6 Oct 2012 21:10:29 -0000 1.14728 +++ gdb/ChangeLog 8 Oct 2012 11:39:39 -0000 @@ -1,3 +1,9 @@ +2012-10-08 Ali Anwar + + * gdbarch.sh (function_list): Use 'pstring' when printing + variable which could return NULL. + * gdbarch.c: Regenerate. + 2012-10-06 Jan Kratochvil Fix crash during stepping on ppc32. Index: gdb/gdbarch.c =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.c,v retrieving revision 1.495 diff -u -r1.495 gdbarch.c --- gdb/gdbarch.c 2 Aug 2012 09:36:38 -0000 1.495 +++ gdb/gdbarch.c 8 Oct 2012 11:39:40 -0000 @@ -1315,16 +1315,16 @@ host_address_to_string (gdbarch->stabs_argument_has_addr)); fprintf_unfiltered (file, "gdbarch_dump: stap_gdb_register_prefix = %s\n", - gdbarch->stap_gdb_register_prefix); + pstring (gdbarch->stap_gdb_register_prefix)); fprintf_unfiltered (file, "gdbarch_dump: stap_gdb_register_suffix = %s\n", - gdbarch->stap_gdb_register_suffix); + pstring (gdbarch->stap_gdb_register_suffix)); fprintf_unfiltered (file, "gdbarch_dump: stap_integer_prefix = %s\n", - gdbarch->stap_integer_prefix); + pstring (gdbarch->stap_integer_prefix)); fprintf_unfiltered (file, "gdbarch_dump: stap_integer_suffix = %s\n", - gdbarch->stap_integer_suffix); + pstring (gdbarch->stap_integer_suffix)); fprintf_unfiltered (file, "gdbarch_dump: gdbarch_stap_is_single_operand_p() = %d\n", gdbarch_stap_is_single_operand_p (gdbarch)); @@ -1339,16 +1339,16 @@ host_address_to_string (gdbarch->stap_parse_special_token)); fprintf_unfiltered (file, "gdbarch_dump: stap_register_indirection_prefix = %s\n", - gdbarch->stap_register_indirection_prefix); + pstring (gdbarch->stap_register_indirection_prefix)); fprintf_unfiltered (file, "gdbarch_dump: stap_register_indirection_suffix = %s\n", - gdbarch->stap_register_indirection_suffix); + pstring (gdbarch->stap_register_indirection_suffix)); fprintf_unfiltered (file, "gdbarch_dump: stap_register_prefix = %s\n", - gdbarch->stap_register_prefix); + pstring (gdbarch->stap_register_prefix)); fprintf_unfiltered (file, "gdbarch_dump: stap_register_suffix = %s\n", - gdbarch->stap_register_suffix); + pstring (gdbarch->stap_register_suffix)); fprintf_unfiltered (file, "gdbarch_dump: gdbarch_static_transform_name_p() = %d\n", gdbarch_static_transform_name_p (gdbarch)); Index: gdb/gdbarch.sh =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.sh,v retrieving revision 1.544 diff -u -r1.544 gdbarch.sh --- gdb/gdbarch.sh 2 Aug 2012 09:36:39 -0000 1.544 +++ gdb/gdbarch.sh 8 Oct 2012 11:39:41 -0000 @@ -809,10 +809,10 @@ # \$10 ;; integer constant 10 # # in this case, this prefix would be the character \`\$\'. -v:const char *:stap_integer_prefix:::0:0::0:gdbarch->stap_integer_prefix +v:const char *:stap_integer_prefix:::0:0::0:pstring (gdbarch->stap_integer_prefix) # Suffix used to mark an integer constant on the architecture's assembly. -v:const char *:stap_integer_suffix:::0:0::0:gdbarch->stap_integer_suffix +v:const char *:stap_integer_suffix:::0:0::0:pstring (gdbarch->stap_integer_suffix) # Prefix used to mark a register name on the architecture's assembly. # For example, on x86 the register name is written as: @@ -820,10 +820,10 @@ # \%eax ;; register eax # # in this case, this prefix would be the character \`\%\'. -v:const char *:stap_register_prefix:::0:0::0:gdbarch->stap_register_prefix +v:const char *:stap_register_prefix:::0:0::0:pstring (gdbarch->stap_register_prefix) # Suffix used to mark a register name on the architecture's assembly -v:const char *:stap_register_suffix:::0:0::0:gdbarch->stap_register_suffix +v:const char *:stap_register_suffix:::0:0::0:pstring (gdbarch->stap_register_suffix) # Prefix used to mark a register indirection on the architecture's assembly. # For example, on x86 the register indirection is written as: @@ -834,7 +834,7 @@ # # Please note that we use the indirection prefix also for register # displacement, e.g., \`4\(\%eax\)\' on x86. -v:const char *:stap_register_indirection_prefix:::0:0::0:gdbarch->stap_register_indirection_prefix +v:const char *:stap_register_indirection_prefix:::0:0::0:pstring (gdbarch->stap_register_indirection_prefix) # Suffix used to mark a register indirection on the architecture's assembly. # For example, on x86 the register indirection is written as: @@ -845,7 +845,7 @@ # # Please note that we use the indirection suffix also for register # displacement, e.g., \`4\(\%eax\)\' on x86. -v:const char *:stap_register_indirection_suffix:::0:0::0:gdbarch->stap_register_indirection_suffix +v:const char *:stap_register_indirection_suffix:::0:0::0:pstring (gdbarch->stap_register_indirection_suffix) # Prefix used to name a register using GDB's nomenclature. # @@ -853,10 +853,10 @@ # language (e.g., \`10\' is the 10th general-purpose register). However, # inside GDB this same register has an \`r\' appended to its name, so the 10th # register would be represented as \`r10\' internally. -v:const char *:stap_gdb_register_prefix:::0:0::0:gdbarch->stap_gdb_register_prefix +v:const char *:stap_gdb_register_prefix:::0:0::0:pstring (gdbarch->stap_gdb_register_prefix) # Suffix used to name a register using GDB's nomenclature. -v:const char *:stap_gdb_register_suffix:::0:0::0:gdbarch->stap_gdb_register_suffix +v:const char *:stap_gdb_register_suffix:::0:0::0:pstring (gdbarch->stap_gdb_register_suffix) # Check if S is a single operand. # --------------000305030700060907010300--