From: Keith Seitz <keiths@redhat.com>
To: dje@google.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] partial fix for 14643
Date: Mon, 01 Oct 2012 18:47:00 -0000 [thread overview]
Message-ID: <5069E52B.60203@redhat.com> (raw)
In-Reply-To: <yjt2wqzaawvr.fsf@ruffy2.mtv.corp.google.com>
On 10/01/2012 11:08 AM, dje@google.com wrote:
> It does not fix "b foo:: thread ::bar()".
> My fix for that is a bit hackish, and that case isn't as important.
Yeah, it's not a big deal IMO, either, but I've been mistaken before.
Naively, I would think keyword_ok could be (un)set whenever a scope
operator is seen. I haven't investigated this at all of course.
> Ok to check in?
You're a global maintainer! :-P FWIW, I think this change is fine.
Inelegant perhaps, but quite honestly, there are too many other, bigger
issues/problems to solve to worry about this.
Keith
next prev parent reply other threads:[~2012-10-01 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 18:08 dje
2012-10-01 18:47 ` Keith Seitz [this message]
2012-10-11 16:58 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5069E52B.60203@redhat.com \
--to=keiths@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox