From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17830 invoked by alias); 28 Sep 2012 19:36:23 -0000 Received: (qmail 17821 invoked by uid 22791); 28 Sep 2012 19:36:22 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Sep 2012 19:36:15 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8SJaDAR018221 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Sep 2012 15:36:13 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8SJaC9l007770; Fri, 28 Sep 2012 15:36:12 -0400 Message-ID: <5065FC2B.6060604@redhat.com> Date: Fri, 28 Sep 2012 19:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 0/11] Cleanup MI test cases References: <1346419770-5718-1-git-send-email-yao@codesourcery.com> <1348790666-2544-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1348790666-2544-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00697.txt.bz2 On 09/28/2012 01:04 AM, Yao Qi wrote: > Hi, > This is a follow up to this thread, > > Re: [RFC] Merge mi-cli.exp and mi2-cli.exp > http://sourceware.org/ml/gdb-patches/2012-09/msg00155.html > > in which we discussed that we are only using mi2 so far and some test > cases are redundant. This patch is to get rid of the redundancy in > test cases. > > Patch 01/11 simply removes mi-FOO.exp, because they are identical to > mi2-FOO.exp. The rest of the patches merge mi-foo.exp with mi2-foo.exp, > and remove mi-foo.exp. This is great, but I think it went the wrong direction. :-/ We have more mi-* files and more changes to mi-* files than the other way around: ls mi-* | wc -l 54 grep-changelog --text "gdb.mi/mi-" ../ChangeLog | grep "^2" | wc -l 412 vs ls mi2-* | wc -l 26 grep-changelog --text "gdb.mi/mi2-" ../ChangeLog | grep "^2" | wc -l 210 And that makes sense because the mi2-* files were originally created as copies of the existing mi-* files, and the mi-* files supposedly continued to evolve, until some point in the future when mi3 would be finalized (at which point we'd again fork the mi3-* copies). The mi2-* file were supposedly cast in stone once the copying was done (on 2003-08-07). Is it hard to redo things a bit to end up with only the mi- files instead? I'd think that something around "mv mi2-foo.exp mi-foo.exp", plus "git add mi-foo.exp", and maybe squash that commit back would get you that effect without needing to really redo things. > Note that this patch set doesn't cover mi2-var-child.exp and > mi-var-child.exp, because they diverge too much for me to handle. -- Pedro Alves