From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9748 invoked by alias); 28 Sep 2012 12:05:55 -0000 Received: (qmail 9703 invoked by uid 22791); 28 Sep 2012 12:05:49 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_EG X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Sep 2012 12:05:35 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8SC5Ysu028087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Sep 2012 08:05:34 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8SC5Wfq010070; Fri, 28 Sep 2012 08:05:33 -0400 Message-ID: <5065928C.2080805@redhat.com> Date: Fri, 28 Sep 2012 12:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: selven CC: gdb-patches@sourceware.org Subject: Re: Redeclaration of regcache_register_status differs from previous declaration References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00683.txt.bz2 On 09/28/2012 12:27 PM, selven wrote: > Hi, I've never submitted a patch to gdb before, I don't know how to do > this, See . > and I searched the wiki couldn't find more info. Yeah, we certainly could do better here. > I was trying to compile gdb on aix > Currently: > gdb/regcache.c > 414 int > 415 regcache_register_status (const struct regcache *regcache, int regnum) > > Definition in regcache.h: > gdb/regcache.h > 66 enum register_status regcache_register_status (const struct > regcache *regcache, > 67 int regnum); > > > Should be: > 414 enum register_status > 415 regcache_register_status (const struct regcache *regcache, int regnum) Whoops. > > (So i kinda decided to post a patch, which sounded awesome :p ) It is. :-) The AIX port is in need of TLC (particularly to adapt it to modern interfaces). It would be great of someone stepped up to give it some. ;-) I've applied this for you. Thanks! 2012-09-28 selven Make definition match declaration. * regcache.c (regcache_register_status): Change return type to enum register_status. --- gdb/regcache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/regcache.c b/gdb/regcache.c index c716280..449f682 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -411,7 +411,7 @@ regcache_dup (struct regcache *src) return newbuf; } -int +enum register_status regcache_register_status (const struct regcache *regcache, int regnum) { gdb_assert (regcache != NULL);