From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3199 invoked by alias); 28 Sep 2012 11:44:18 -0000 Received: (qmail 3191 invoked by uid 22791); 28 Sep 2012 11:44:17 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Sep 2012 11:44:08 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8SBi6vu019881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Sep 2012 07:44:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8SBi4Ta013480; Fri, 28 Sep 2012 07:44:05 -0400 Message-ID: <50658D84.1090309@redhat.com> Date: Fri, 28 Sep 2012 11:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Anton Blanchard CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Support up to 3 conditional branches in an atomic sequence References: <20120606135557.7da37cbe@kryten> <20120606135655.57bd5b54@kryten> <20120613160208.GH18729@adacore.com> <20120716163355.74acba34@kryten> In-Reply-To: <20120716163355.74acba34@kryten> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00682.txt.bz2 Hi Anton, Just some notes on the ChangeLog formatting: On 07/16/2012 07:33 AM, Anton Blanchard wrote: > 2012-06-05 Anton Blanchard > > * gdb/breakpoint.h: Define MAX_SINGLE_STEP_BREAKPOINTS > * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Allow for more > than two breakpoints. > * gdb/breakpoint.c (insert_single_step_breakpoint): Likewise > (insert_single_step_breakpoint): Likewise > (single_step_breakpoints_inserted): Likewise > (cancel_single_step_breakpoints): Likewise > (detach_single_step_breakpoints): Likewise > (single_step_breakpoint_inserted_here_p): Likewise - Please add a period at the end of these sentences. - Remove the gdb/ from the breakpoint.h|c entries. I suggest: 2012-09-28 Anton Blanchard * breakpoint.h (MAX_SINGLE_STEP_BREAKPOINTS): New define. * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Allow for more than two breakpoints. * breakpoint.c (insert_single_step_breakpoint): Likewise. (insert_single_step_breakpoint): Likewise. (single_step_breakpoints_inserted): Likewise. (cancel_single_step_breakpoints): Likewise. (detach_single_step_breakpoints): Likewise. (single_step_breakpoint_inserted_here_p): Likewise. -- Pedro Alves