From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94866-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20037 invoked by alias); 26 Sep 2012 15:06:44 -0000
Received: (qmail 20028 invoked by uid 22791); 26 Sep 2012 15:06:43 -0000
X-SWARE-Spam-Status: No, hits=-8.0 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 15:06:29 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QF6SEI001767	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 26 Sep 2012 11:06:29 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8QF6RkO026909;	Wed, 26 Sep 2012 11:06:28 -0400
Message-ID: <506319F3.20005@redhat.com>
Date: Wed, 26 Sep 2012 15:06:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1
MIME-Version: 1.0
To: Andrew Burgess <aburgess@broadcom.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH] Failure to stop at duplicate breakpoints
References: <505B31C2.5010203@broadcom.com> <m31uhwfsh5.fsf@redhat.com> <505BA4D2.7070104@broadcom.com> <5061D8B8.2050209@redhat.com> <50622695.3040002@broadcom.com>
In-Reply-To: <50622695.3040002@broadcom.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00589.txt.bz2

On 09/25/2012 10:48 PM, Andrew Burgess wrote:
> Pedro,
> 
> Thanks for taking the time to review my patch.  I've addressed the issues you raised, and 

Great, thanks.  Just one little more I missed before:

> +standard_testfile
> +
> +if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
> +    return -1
> +}
> +
> +# Setup for the test, create COUNT breakpoints at the function BREAKPT.
> +proc test_setup { count } {
> +    global srcfile

    global binfile

and

> +    clean_restart duplicate-bp

instead:

    clean_restart $binfile

Okay with that change.  Thanks again.

-- 
Pedro Alves