From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cVkeDgpy1mpnPzQAWB0awg (envelope-from ) for ; Mon, 19 Oct 2026 15:39:54 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=cApPA3Iw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 356511E050; Mon, 19 Oct 2026 15:39:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 64C611E04D for ; Mon, 19 Oct 2026 15:39:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE00A4BA23F6 for ; Mon, 19 Oct 2026 19:39:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE00A4BA23F6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=cApPA3Iw Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::3]) by sourceware.org (Postfix) with ESMTPS id B42674BA23F5; Mon, 19 Oct 2026 19:36:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B42674BA23F5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B42674BA23F5 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1792438589; cv=pass; b=a7TK2IwCzm1hovqOmf0Az6VFMhpbbimL+Wx5skYk8nSiihZBf8JRZGar64QLIVDUTwwUreaWoaG+hzk9+0Gmg/ZMtTN5TlayFAdJy/+B9+x3igMuZujfkn8poTUCJUoYQGe1589YVDGVJxfx0udAOnNWKBGg73De9Cf4EN31W+4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1792438589; c=relaxed/simple; bh=nkdDEYBVYcsyMlhsBAbWRg8ak7Ksc00Drrm2nKVEPdQ=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=NYei8erF51b+p4eApDWspjT+w5RwK4upjUU+fKZgTh/QaE1k3k55ITeqrw0qaJLlYWExZvg4cGWT9uDktW87OkQHdFKNnTVGeOusdUEftE+vuoVCm7JdhyYP+jCCr9BsDjDP0etSF5EnAUePHqa/fNhSfsPtdmUgUOjkur9JQMY= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=cApPA3Iw DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B42674BA23F5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OsvIKPUBQaEGiLgogftS/n1UEwTBtYaLny46qFtPAnbgOmfpRD7hsFV44WFNSKEF1KlcZSFIzBR3mRfMLnbtr4almNjmbcjC0Anoxq6eORhucyKv1d85qGo7zxrvwG6KfC4gUUaMpfMtT7A7Csn4PvHdLAEuWJL10Ia2N1nfx1BNnVJ+i5MwGF1aN4CXDDWouptsokBuh/zd9kc74z2uP5tCwqIbMBzUwR47oy6t+18uGlz8vwOBhedYk7GTr3/plNcXDNmTKlS+bjkrjUW+mlpxqxOGno1QJ6JEbc04XqemjAOZdaoYTdNlAGuGzHNDqYlV0ow4ZvsF5L5fhKrHkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dn2KZM7rbj9cZA9jhJXu//P/8BXMSB2JQjoKYnwq7Ug=; b=wmxY3wexUnmrTclMWQJKErd0CX9ECC7S7tNZvraY5U1LPYkmrdXdXC1XFd33gMKXGGLVLHDq9ZaExI+BFilFRlZ6FkNc+4kLxoWRJpLJEoUUKpCJ3048hm6qyPSVHjgzJLphtjQhlX5FPwO6A0UaJQ21Q5W1SfQjya956wMWqlErkgswzHa+jqyLDFf4rSfVuy+pdxSXq875juFLtlu4u84aPipraS9KBFHNpPYyfqbl13WG9fghsds/WXHaS3O/XdsG/MiOcSNJ1HFkP8+0adHN2ZP6dYfbPXJDSb7McOWc0V71AiOJdyhDaY7Ux2hnLQsFYbyia/ff9eQa4vJ3iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dn2KZM7rbj9cZA9jhJXu//P/8BXMSB2JQjoKYnwq7Ug=; b=cApPA3Iw9Ww14fmWE2xRSFl5hQwEHgCAftZmfFMfAYnztuEJfpalBbpQWp4wHvFbw5pqdG2MkPCfZbR/cErBIUY60DRUrddbYJ1zdfBws0wCdTN5uNXIeS8U/KyheGxC17AeNtLnGsUfVLnBU1Zp4/pGKKw6eo1HPSt2b3fAREl6mOz7x4mvhIHHg4lEVh0GmxaLp2SVhAKoneYSmnliav5FhbMg0tjGe0XjjziBnx+QCaOe8GKsV27kaQzz+sKMyBslJ5X2PqF1hGbQy+ApGxaY+45NLnM2zdr0ZaypJvpMth/qOytMeYUJNsXzR/A3eD241jeIiZOuSxXgRhWxuQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT2PR01MB9015.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.19; Mon, 19 Oct 2026 19:36:28 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0522.017; Mon, 19 Oct 2026 19:36:28 +0000 Message-ID: <50618a5e-0c68-4380-b2b3-32f3ed487b67@efficios.com> Date: Mon, 19 Oct 2026 15:36:26 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/18] sim/m68hc11: remove unused current_insn_size variable To: binutils@sourceware.org, gdb-patches@sourceware.org References: <20261019193231.1708375-1-simon.marchi@efficios.com> <20261019193231.1708375-12-simon.marchi@efficios.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20261019193231.1708375-12-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQ1P288CA0006.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:9e::16) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT2PR01MB9015:EE_ X-MS-Office365-Filtering-Correlation-Id: 3140c279-eb91-4e1d-64cc-08df2e18453c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|1800799024|376014|4143699003|56012099006|261009223027099003|10067099003|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: l3rdbcdmvcOPqBud6lpBJrMTDKf88lTZBbmx46Zbk6C5+WNFcHvs5SYrMooMd3qhFRzO/uO7AswVsvP6R4nR98Ig3DygltR3/plzVk6uX1vwadgkA52fdeDoSEHKv5M1zTOcxKU0aaoZzRSeSK8W1eLHtBgvsc28S31SihbTlUw2KhtrJQo71+cdl5o67BrnuJjXoi2NtdpFNedMVZXkp4g3JsKVdNKH6CCh+lsZwh9Ao6g1TGFECI6NqL8BIairQmBy5LnkJoliaMJFEoXr5+XtXEyQp+CMGBspmyfkYkqW2pFOgEjj+0k4Cs6dX6nCv7Mx42pV+KiYz816BrVDlHsLDsEPfVNsuPSF1U2ROvlx+VAJob6Sfp3aGKG0Wuu5KYJd2IQzLzL6gCZRRCkKfQSCxdy2YPW1xqFdt8RU8SWej36KV/faBFsDaW7FjdoPFeWuz7Os2fzvHJn8GdNnxcQTY5nQGngYSE2SHcFFETxmJe4KKhUSyVCaR71QyuxZIlN9z99vt1dDHcHsk/nmdqKr4xDj+GJ5kyaKAQfJbgo4swk1Qv3aXbI8UTtcvfMw0JEvndI1WC2osP5m42CKfLuJghNmlDmhCsmZb3anISisBTGurXLCak3M0+SuG0jUTfmwQlu9xOw3mlmGS5tJ8weXgByPmpKb698c0jY/8qU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(4143699003)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003)(3023799007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vnh6QUlBbVJCTG5STmRSWXVOenZmaUZsTlB5dnIxNWN0VzRlRU1kVHpybE4w?= =?utf-8?B?dGpwdzFCSEJZeDRZMXN6Z25VTVhmTGNWNHA3OWJYRkd1ZTdDRThYV2pJSmJw?= =?utf-8?B?c2NrQzJVY2U4WEZHTkNjZTJPWklqbDhuaWtabUN1aTBoUEhzMG5JclBuRlVQ?= =?utf-8?B?RHJKRzFyWlk4bFcwZkxmM2drbXNKSnZmbHQxTWc2QnE2ZjN3emZjL1dRbC9X?= =?utf-8?B?S3VDMkRqSG9nd2FJaURBN3ByTVp6SURpcXVwQkQ2b1BvWmpTM2hLTnduZG1j?= =?utf-8?B?dm01SlFWdUF1dFZ6RDM4Wm1vbVVQTDNlS21DbzcrYmVGVitOTSs4UGoxMzJW?= =?utf-8?B?UXIwMjFXeldaNUQ5c1VPaEM0cVJCZWpyYVkvUG44aXJLWmViUE5JVS9nOCtn?= =?utf-8?B?RktHYUFHdS9xaDFDTG5CbThmSUZMY2FEVjBXQkJDUU4rOXJDdWpGV3FUZk83?= =?utf-8?B?WmlGb0VLZWVuZmJIT3VUdWo2RTRLTlJ3emFKNDYrbVJaYk52QnplNFlMTm5z?= =?utf-8?B?SVdzdDBTRjh6YXk4VWlqTGFXOEZiNmMvVXViQWtsT2RoQTRwOVRVVkN6TFhC?= =?utf-8?B?Z0F3QTQzcW5oeGxnVFp4YSs3ajY0MllsYVV6N3VFK3EyeUpVcXVJNVI3cTl6?= =?utf-8?B?aFRCcW5yaGpIdUFUM1hERTRHZUphRjRnRC9RMTFSUlVSWUlqSUwxem9jejkw?= =?utf-8?B?WHlUWmlCYVZMQ1lKWFZRam1RR0Z5VzVlbzhUOE1reUU2cGdpUVVRZjNxdVl3?= =?utf-8?B?emY0S1preHpmOFl3MkI4QzEwTGNvUUpGRGhNRE9VYnBOWEtwL1ZxcjZUY2Fi?= =?utf-8?B?V3Myb3JEZlZVL3U5UGpHYnFreElKTDdiMk90dzQ5U1RNTlpwMzR5Q1krbXJS?= =?utf-8?B?UDc3bC90VmpQVHFmeG9lalhZWS9naklLZEFJUU5FaXdKM05QY0dPVmJtQUx2?= =?utf-8?B?QnVMckZNZUoyanBaUWxUeWZkWUYyeHhvT0JDdXRRTURVL1VCT3ljR0tjanFN?= =?utf-8?B?aERtU2hEV3hMTW11OTRDbms3NFVXY1ArS2czZmxMSWRnYkN3Q01XaURLQ3VY?= =?utf-8?B?WVNRdTJCaEozS2pseTVPWG9hbUpYVFo4ZWc0alo0bmFFR2ljZVhvQkdsanlp?= =?utf-8?B?akFRaGtodWZISzg2czBSVisxVXZGVHBZcFE4c3pnR21Ic0FJOWNnVVUreGFX?= =?utf-8?B?dUYzTmxycjYwVzlHdDQ3SjZMQVUyMnpUV2ZPWGxDalZKWkpSOW5iMHRxWS9X?= =?utf-8?B?dnR4b2pSMWdUTDZ0WFZJd2hYdDY5QkNpY3hLMk8rd1VDeXRVYXZyQktEOUxI?= =?utf-8?B?U3pyQjd2eVVwUnoyVzdVeVRmQSttdVNRaXROcHFnVlk2QkppTTdzeEU2VFNO?= =?utf-8?B?RUdHbUVhano5azdZNjAzRkdZT1JJNS91c1RocitVZHl3Y2xOeUdMRWZRNE0z?= =?utf-8?B?c0kwV1JrczNhNEFYd0I4U1NvUVdPaFNvOFAyTHdZZWk3bUpRUW1EZVlIN0hZ?= =?utf-8?B?TUs4MmF4dXhYckZtei8vdEVRTHJxUWlIazNEMG1acVAxSXp2ajFrcWU4bWIr?= =?utf-8?B?ZWZ6T3pNTWhDQnlNdTNjSVphdlZ3czBEeFlyVHd4MTJTVjZZT2lMblMxRnN6?= =?utf-8?B?aUtKSVd6T0lDa29DM0NNNGUySlovQzJab0VmTEJTSmdScGlVNks1N2YvWXVB?= =?utf-8?B?Z0lucTNnbjNYYnpSQkFVVHl4b2FXbk5scWM0emhYK3lvdUNUS3JKcnhHZ3pa?= =?utf-8?B?MTJJOGhDUjB2OVRUTWRHMjFZUHlyTTdxclJvMVBlQ1h4Ukh1OFU3Q1h3T2RB?= =?utf-8?B?ZjFJUTdRUk1NbWdqeWh2ZEFoMjQ5UUZMSit3dWpXb0tRUDZpYlRyQncxKytv?= =?utf-8?B?ejRxOEF2RnVUdDdUSzF5UktsSENLY2RZZDV3cS80emtvMncxaW5NK3RlNk1z?= =?utf-8?B?UTgxOFhrUmRaZTB6a1N1ZC9OdVE5cklSaVdzVW0ydDJ1YVJoZGVwWE9reXV2?= =?utf-8?B?RDFyWEtEWWVFSFl6aTZJeVNNM3dOZ2pNbjdldHNiRGVCVGErRHV6SVQyZnJx?= =?utf-8?B?czNNdGdQMjU1SFZGVW9ablAvN1MrNFZibzRXN0ZLU1p2bElNSFo5dFQxeHB2?= =?utf-8?B?Y2lMLzFvYTV6ckx6Y1dDeFN4MnpHU0pra2hUaEhETWxtcDJRN0ZRbzlBOGM2?= =?utf-8?B?aXpHdEEwc29qdy8rUVZzMUtXbFhSQjR1cFpCME90dWRhMWlnZVJOeW81OElm?= =?utf-8?B?OTFBRzkzeW5SblpQVkx3blJJQXNEMkZ0NnhyZEVYQjIyMkNDU3lKZ3VxUmRi?= =?utf-8?B?cllmMWQzNzM4dkhYU0V5K25NVVVncGVjaEsxdzVyL2xGU2M2U2Nzdz09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3140c279-eb91-4e1d-64cc-08df2e18453c X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2026 19:36:28.6468 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UbWHUG8wlz7shmNKWID8xgBGYhS2xAVOBB6fgTmYiQ02iSs/Kuf3tD0h1KKtIJyxYNtnp8sXGz/n3xblfNZhxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB9015 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Adding gdb-patches@. On 10/19/26 3:28 PM, Simon Marchi wrote: > Building the m68hc11 simulator with a recent clang fails with: > > /home/smarchi/src/binutils-gdb/sim/m68hc11/gencode.c:1143:12: error: variable 'current_insn_size' set but not used [-Werror,-Wunused-but-set-global] > > The only read of current_insn_size is an instruction size consistency > check, which has been disabled with "#if 0" since commit 81e09ed8322b > ("Improve HC11 simulator to support HC12", 2001-05-20). Remove the > variable, the code computing it, and the disabled check. > > Change-Id: Ibd7ee5ac16d5511d40a9ddcc175a94dcbc387b2b > --- > sim/m68hc11/gencode.c | 41 ----------------------------------------- > 1 file changed, 41 deletions(-) > > diff --git a/sim/m68hc11/gencode.c b/sim/m68hc11/gencode.c > index 248005a9dd84..822c90ef9a5e 100644 > --- a/sim/m68hc11/gencode.c > +++ b/sim/m68hc11/gencode.c > @@ -1140,7 +1140,6 @@ static struct m6811_opcode_def m6812_page2_opcodes[] = { > > > static int indent_level = 2; > -static int current_insn_size = 0; > > /* Fatal error message and exit. This method is called when an inconsistency > is detected in the generation table. */ > @@ -1344,7 +1343,6 @@ gen_fetch_operands (FILE *fp, int col, > fatal_error (opcode, "Wrong use of '*', 'addr' already used"); > > addr_set = 1; > - current_insn_size += 1; > print (fp, col, "addr = (uint16_t) cpu_fetch8 (cpu);"); > print (fp, col, "%s%s = memory_read%s (cpu, addr);", > vars[cur_var], operand_size, operand_size); > @@ -1357,25 +1355,21 @@ gen_fetch_operands (FILE *fp, int col, > addr_set = 1; > if (strncmp (operands, "(x)", 3) == 0) > { > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_x (cpu) + (uint16_t) cpu_fetch8 (cpu);"); > operands += 3; > } > else if (strncmp (operands, "(y)", 3) == 0) > { > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_y (cpu) + (uint16_t) cpu_fetch8 (cpu);"); > operands += 3; > } > else if (strncmp (operands, "()", 2) == 0) > { > - current_insn_size += 2; > print (fp, col, "addr = cpu_fetch16 (cpu);"); > operands += 2; > } > else if (strncmp (operands, "[]", 2) == 0) > { > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_indexed_operand_addr (cpu, 0);"); > operands += 2; > } > @@ -1395,7 +1389,6 @@ gen_fetch_operands (FILE *fp, int col, > if (strncmp (operands, "x)", 2) == 0) > { > addr_set = 1; > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_x (cpu) + (uint16_t) cpu_fetch8 (cpu);"); > print (fp, col, "%s%s = memory_read%s (cpu, addr);", > vars[cur_var], operand_size, operand_size); > @@ -1404,7 +1397,6 @@ gen_fetch_operands (FILE *fp, int col, > else if (strncmp (operands, "y)", 2) == 0) > { > addr_set = 1; > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_y (cpu) + (uint16_t) cpu_fetch8 (cpu);"); > print (fp, col, "%s%s = memory_read%s (cpu, addr);", > vars[cur_var], operand_size, operand_size); > @@ -1413,7 +1405,6 @@ gen_fetch_operands (FILE *fp, int col, > else if (strncmp (operands, ")", 1) == 0) > { > addr_set = 1; > - current_insn_size += 2; > print (fp, col, "addr = cpu_fetch16 (cpu);"); > print (fp, col, "%s%s = memory_read%s (cpu, addr);", > vars[cur_var], operand_size, operand_size); > @@ -1421,7 +1412,6 @@ gen_fetch_operands (FILE *fp, int col, > } > else if (strncmp (operands, "@)", 2) == 0) > { > - current_insn_size += 2; > print (fp, col, "addr = cpu_fetch16 (cpu);"); > print (fp, col, "%s%s = memory_read%s (cpu, addr);", > vars[cur_var], operand_size, operand_size); > @@ -1451,7 +1441,6 @@ gen_fetch_operands (FILE *fp, int col, > if (strncmp (operands, "]", 1) == 0) > { > addr_set = 1; > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_indexed_operand_addr (cpu,0);"); > print (fp, col, "%s%s = memory_read%s (cpu, addr);", > vars[cur_var], operand_size, operand_size); > @@ -1461,7 +1450,6 @@ gen_fetch_operands (FILE *fp, int col, > removed because it may be that there is a typo in strncmp test below. */ > else if (strncmp (operands, "]", 1) == 0) > { > - current_insn_size += 1; > print (fp, col, "%s%s = cpu_get_indexed_operand%s (cpu,0);", > vars[cur_var], operand_size, operand_size); > operands += 1; > @@ -1482,7 +1470,6 @@ gen_fetch_operands (FILE *fp, int col, > > if (strncmp (operands, "}", 1) == 0) > { > - current_insn_size += 1; > print (fp, col, "%s%s = cpu_get_indexed_operand%s (cpu, 1);", > vars[cur_var], operand_size, operand_size); > operands += 1; > @@ -1525,7 +1512,6 @@ gen_fetch_operands (FILE *fp, int col, > fatal_error (opcode, "Wrong use of 'r'"); > > addr_set = 1; > - current_insn_size += 1; > print (fp, col, "addr = cpu_fetch_relbranch (cpu);"); > break; > > @@ -1534,19 +1520,10 @@ gen_fetch_operands (FILE *fp, int col, > fatal_error (opcode, "Wrong use of 'R'"); > > addr_set = 1; > - current_insn_size += 2; > print (fp, col, "addr = cpu_fetch_relbranch16 (cpu);"); > break; > > case '#': > - if (strcmp (operand_size, "8") == 0) > - { > - current_insn_size += 1; > - } > - else > - { > - current_insn_size += 2; > - } > print (fp, col, "%s%s = cpu_fetch%s (cpu);", vars[cur_var], > operand_size, operand_size); > break; > @@ -1655,7 +1632,6 @@ gen_save_result (FILE *fp, int col, > case '*': > if (addr_set == 0) > { > - current_insn_size += 1; > print (fp, col, "addr = (uint16_t) cpu_fetch8 (cpu);"); > } > result_size = operand_size; > @@ -1668,7 +1644,6 @@ gen_save_result (FILE *fp, int col, > { > if (addr_set == 0) > { > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_x (cpu) + cpu_fetch8 (cpu);"); > } > print (fp, col, "memory_write%s (cpu, addr, dst%s);", > @@ -1680,7 +1655,6 @@ gen_save_result (FILE *fp, int col, > { > if (addr_set == 0) > { > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_y (cpu) + cpu_fetch8 (cpu);"); > } > print (fp, col, "memory_write%s (cpu, addr, dst%s);", > @@ -1692,7 +1666,6 @@ gen_save_result (FILE *fp, int col, > { > if (addr_set == 0) > { > - current_insn_size += 2; > print (fp, col, "addr = cpu_fetch16 (cpu);"); > } > print (fp, col, "memory_write%s (cpu, addr, dst%s);", > @@ -1719,7 +1692,6 @@ gen_save_result (FILE *fp, int col, > { > if (addr_set == 0) > { > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_indexed_operand_addr (cpu,0);"); > } > print (fp, col, "memory_write%s (cpu, addr, dst%s);", > @@ -1736,7 +1708,6 @@ gen_save_result (FILE *fp, int col, > case '{': > if (strncmp (operands, "}", 1) == 0) > { > - current_insn_size += 1; > print (fp, col, "addr = cpu_get_indexed_operand_addr (cpu, 1);"); > print (fp, col, "memory_write%s (cpu, addr, dst%s);", > operand_size, operand_size); > @@ -1880,11 +1851,7 @@ gen_interpreter_for_table (FILE *fp, int col, > const char *cycles_table_name) > { > int i; > - int init_size; > > - init_size = table == m6811_page1_opcodes > - || table == m6812_page1_opcodes? 1 : 2; > - > /* Get the opcode and dispatch directly. */ > print (fp, col, "op = cpu_fetch8 (cpu);"); > print (fp, col, "cpu_add_cycles (cpu, %s[op]);", cycles_table_name); > @@ -1899,15 +1866,7 @@ gen_interpreter_for_table (FILE *fp, int col, > if (i > 0 && table[i].insn_code == table[i - 1].insn_code) > continue; > > - current_insn_size = init_size; > gen_interp (fp, col, &table[i]); > -#if 0 > - if (current_insn_size != table[i].insn_size) > - { > - fatal_error (&table[i], "Insn size %ld inconsistent with %ld", > - current_insn_size, table[i].insn_size); > - } > -#endif > } > > print (fp, col, "default:\n"); > -- > 2.56.0 >