Re: [PATCH 4/8] Enable SVE for GDB

Pedro Alves
2018-05-31T14:57:25Z

On 05/11/2018 11:52 AM, Alan Hayward wrote:
> + if (feature_sve != NULL)
> + {
> + gdb_assert (feature_fpu == NULL);
> +
> + /* Validate the descriptor provides the mandatory sve registers

"description". Please "grep -i" your patches for "descriptor", since
this appears in other spots.

Uppercase "SVE", I'd assume. I noticed that at least patch #8 uses
lowercase "sve" in an error message, which should probably be fixed.
Suggest grepping the patches for that too.

> + and allocate their numbers. */
> + for (i = 0; i < ARRAY_SIZE (aarch64_sve_register_names); i++)
> + valid_p &= tdesc_numbered_register (feature_sve, tdesc_data,

Thanks,
Pedro Alves