Re: [PATCH 5/8] Add aarch64 psuedo help functions

Simon Marchi
2018-05-31T12:06:34Z

psuedo -> pseudo in the title.

On 2018-05-11 06:52 AM, Alan Hayward wrote:
> Reduce code copy/paste by adding two helper functions for
> aarch64_pseudo_read_value and aarch64_pseudo_write
> The patch does not change any functionality.
>
> 2018-05-11 Alan Hayward <alan.hayward@arm.com>
>
> * aarch64-tdep.c (aarch64_pseudo_read_value_2): New helper func.
> (aarch64_pseudo_write_2): Likewise.
> (aarch64_pseudo_read_value): Use helper.
> (aarch64_pseudo_write): Likewise.
> ---
> gdb/aarch64-tdep.c | 173 +++++++++++++++++------------------------------------
> 1 file changed, 54 insertions(+), 119 deletions(-)
>
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 7893579d58..003fefb3c9 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -2247,109 +2247,67 @@ aarch64_pseudo_register_reggroup_p (struct gdbarch *gdbarch, int regnum,
> return group == all_reggroup;
> }
>
> +/* Inner version of aarch64_pseudo_read_value. */
> +
> +static struct value *
> +aarch64_pseudo_read_value_2 (readable_regcache *regcache, int regnum_offset,
> + int regsize, struct value *result_value)

It's not a big deal, but in other GDB parts we actually often use the _1 suffix
for the helper functions.

But otherwise, LGTM.

Simon