Re: [PATCH 5/8] Add aarch64 psuedo help functions

Pedro Alves
2018-05-31T14:58:00Z

On 05/31/2018 01:06 PM, Simon Marchi wrote:

>> +/* Inner version of aarch64_pseudo_read_value. */
>> +
>> +static struct value *
>> +aarch64_pseudo_read_value_2 (readable_regcache *regcache, int regnum_offset,
>> + int regsize, struct value *result_value)
>
> It's not a big deal, but in other GDB parts we actually often use the _1 suffix
> for the helper functions.
>

Also, I'd think "Helper for aarch64_pseudo_read_value." would be clearer,
because "inner version" sounds a bit odd to me.

> But otherwise, LGTM.

To me too.

Thanks,
Pedro Alves