From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5751 invoked by alias); 1 Dec 2016 18:05:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5741 invoked by uid 89); 1 Dec 2016 18:05:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=45pm X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Dec 2016 18:05:32 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD8F5C04B326; Thu, 1 Dec 2016 18:05:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB1I5UfS005239; Thu, 1 Dec 2016 13:05:31 -0500 Subject: Re: [PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer To: Yao Qi References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> <1480591000-19457-1-git-send-email-yao.qi@linaro.org> <20161201152115.GB19289@E107787-LIN> <20161201160412.GC19289@E107787-LIN> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <505a5ab1-fce2-8ad1-3f10-62dfef6be4f4@redhat.com> Date: Thu, 01 Dec 2016 18:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161201160412.GC19289@E107787-LIN> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00049.txt.bz2 On 12/01/2016 04:04 PM, Yao Qi wrote: > On Thu, Dec 01, 2016 at 03:21:15PM +0000, Yao Qi wrote: >> On Thu, Dec 01, 2016 at 12:57:45PM +0000, Pedro Alves wrote: >>> On 12/01/2016 11:16 AM, Yao Qi wrote: >>> >>>> +#if GDB_SELF_TEST >>>> + >>>> +namespace selftests >>>> +{ >>>> + >>>> + /* Instruction reader from manually cooked instruction sequences. */ >>>> + >>>> + class instruction_reader_test : public abstract_instruction_reader >>>> + { >>> >>> This whole class should be indented at column 0. >>> >> >> Hi Pedro, >> That is how emacs indents my code (at column 2). Even I start emacs >> with -q, it still indents that way. >> > > I managed to get emacs indent at column 0 with the following changes in > gdb/.dir-locals.el. That unfortunately somehow makes emacs indent members of classes (even if not in a namespace) at column 0, like: struct foo { int a; }; Do you get that too? BTW, the don't-indent-body-of-namespace guideline is here: https://gcc.gnu.org/codingconventions.html#Namespace_Form and it does look like GCC generally follows it. (The '{'-on-same-line rule is there too.) Thanks, Pedro Alves