From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20092 invoked by alias); 18 Sep 2012 14:36:11 -0000 Received: (qmail 19988 invoked by uid 22791); 18 Sep 2012 14:36:09 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 14:35:51 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TDyty-0000T3-Hy from Yao_Qi@mentor.com ; Tue, 18 Sep 2012 07:35:50 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 18 Sep 2012 07:35:50 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Tue, 18 Sep 2012 07:35:49 -0700 Message-ID: <5058868F.7070703@codesourcery.com> Date: Tue, 18 Sep 2012 14:36:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Marc Khouzam CC: "'gdb-patches@sourceware.org'" Subject: Re: [RFC 0/2, gdbserver] Set linux target in async mode in default References: <1347961672-18495-1-git-send-email-yao@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00359.txt.bz2 On 09/18/2012 10:12 PM, Marc Khouzam wrote: > To clarify, after this patch we can still use "-gdb-set target-async off" > to turn off async mode right? > This patch doesn't change the behaviour from the GDB's and Eclipse's perspective. We can still set target-async on or off in GDB side as needed. IIUC, the term "async mode" in GDBserver is different from its counterpart in GDB. In GDBserver, "async mode" means an "async event loop" which is used for non-stop and notification. If we look at RSP, there is no command to turn "async mode" on or off directly in GDBserver (QNonStop can start async mode on linux target), the state of "async mode" of GDBserver is unknown to GDB, and vice versa. In current GDBserver/linux, we have only two modes, 'non-stop with async-event-loop' and 'all-stop without async-event-loop'. This patch only changes the latter to 'all-stop with async-event-loop', so that async notification can work on top it. At the same time, GDB still works in both "target-async on" and "target-async off" with this patched GDbserver. > Eclipse currently uses non-async mode for all-stop and some code > is based on that assumption (e.g., interrupting the target) > so we need to keep non-async available. Forgot to mention in my mail that I run testsuite with {native-gdbserver, native-extended-gdbserver} x {async, sync} (in GDB side), and no regression. -- Yao