From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14156 invoked by alias); 18 Sep 2012 08:48:39 -0000 Received: (qmail 14142 invoked by uid 22791); 18 Sep 2012 08:48:36 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 08:47:59 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TDtTK-0001wt-1a from Yao_Qi@mentor.com ; Tue, 18 Sep 2012 01:47:58 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 18 Sep 2012 01:47:57 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Tue, 18 Sep 2012 01:47:56 -0700 Message-ID: <50583505.9030006@codesourcery.com> Date: Tue, 18 Sep 2012 08:48:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Eli Zaretskii CC: Subject: Re: [PATCH] traceframe_changed observer and MI notification References: <1346404195-20864-1-git-send-email-yao@codesourcery.com> <5057BB72.9070305@codesourcery.com> <83pq5j257w.fsf@gnu.org> <50582156.50107@codesourcery.com> <83lig72206.fsf@gnu.org> In-Reply-To: <83lig72206.fsf@gnu.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00347.txt.bz2 On 09/18/2012 04:01 PM, Eli Zaretskii wrote: > Then that line should be deleted. > OK. >>> > >Also, I don't understand the significance of the reference to >>> > >'tfind'. Why is it important to mention that? >>> > > >> > >> >because users use command 'tfind' to examine a certain traceframe, and >> >the changes of traceframe trigger this MI notification, so I mention >> >'tfind' here. > The text you wrote can be interpreted as if using 'tfind' was the only > way to change the trace frame. If that's not true, 'tfind' it should > be mentioned in parentheses, something like > > (e.g., by using the @code{tfind} command) How about the new one? -- Yao gdb/doc: * observer.texi (GDB Observers): New observer 'traceframe_changed'. * gdb.texinfo (GDB/MI Async Records): Mention new MI notification '=traceframe-changed'. gdb: * NEWS: Mention the new MI notification. --- diff --git a/gdb/NEWS b/gdb/NEWS index dba6937..126c2af 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -43,6 +43,8 @@ py [command] ** Command parameter changes are now notified using new async record "=cmd-param-changed". + ** Trace frame changes caused by command "tfind" are now notified using + new async record "=traceframe-changed". *** Changes in GDB 7.5 diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index dc8860a..ee03521 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -27633,6 +27633,12 @@ thread group in whose context the library was unloaded. If the field is absent, it means the library was unloaded in the context of all present thread groups. +@item =traceframe-changed,num=@var{tfnum},tracepoint=@var{tpnum} +@itemx =traceframe-changed,end +Reports that the trace frame was changed and its new number is +@var{tfnum}. The number of the tracepoint associated with this trace +frame is @var{tpnum}. + @item =breakpoint-created,bkpt=@{...@} @itemx =breakpoint-modified,bkpt=@{...@} @itemx =breakpoint-deleted,id=@var{number} diff --git a/gdb/doc/observer.texi b/gdb/doc/observer.texi index c81e137..f682e9e 100644 --- a/gdb/doc/observer.texi +++ b/gdb/doc/observer.texi @@ -187,6 +187,13 @@ A tracepoint has been modified in some way. The argument @var{tpnum} is the number of the modified tracepoint. @end deftypefun +@deftypefun void traceframe_changed (int @var{tfnum}, int @var{tpnum}) +The trace frame is changed to @var{tfnum} (e.g., by using the +@code{tfind} command). The number of the tracepoint associated with +this traceframe is @var{tpnum}. If @var{tfnum} is negative, it means +@value{GDBN} resumes live debugging. +@end deftypefun + @deftypefun void architecture_changed (struct gdbarch *@var{newarch}) The current architecture has changed. The argument @var{newarch} is a pointer to the new architecture. ---