From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5059 invoked by alias); 15 Sep 2012 07:40:29 -0000 Received: (qmail 4843 invoked by uid 22791); 15 Sep 2012 07:40:27 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_EG X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 15 Sep 2012 07:40:13 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TCmz5-0001LL-Ie from Yao_Qi@mentor.com ; Sat, 15 Sep 2012 00:40:11 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 15 Sep 2012 00:40:11 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Sat, 15 Sep 2012 00:40:10 -0700 Message-ID: <505430A6.8060902@codesourcery.com> Date: Sat, 15 Sep 2012 07:40:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: CC: Subject: Re: [patch] callfuncs.exp: set unwindonsignal on References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00299.txt.bz2 On 09/15/2012 06:34 AM, dje@google.com wrote: > Hi. > > Testing cvs head with i686 binaries and 64-bit gdb has this failure: > FAIL: gdb.base/callfuncs.exp: gdb function calls preserve register contents > [I'm guessing the same failure will be seen with 32-bit native.] > This fail was introduced by my patch (sorry), [_Complex test 4/4] _Complex tests in callfuncs.exp http://sourceware.org/ml/gdb-patches/2011-05/msg00421.html and it exists on 32-bit native. > > Index: callfuncs.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/callfuncs.exp,v > retrieving revision 1.52 > diff -u -p -r1.52 callfuncs.exp > --- callfuncs.exp 9 Jul 2012 14:20:52 -0000 1.52 > +++ callfuncs.exp 14 Sep 2012 22:29:09 -0000 > @@ -65,6 +65,10 @@ proc do_function_calls {} { > # We need to up this because this can be really slow on some boards. > set timeout 60; > > + # If any of these calls segv we don't want to affect subsequent tests. > + # E.g., we want to ensure register values are restored. > + gdb_test_no_output "set unwindonsignal on" > + > gdb_test "p t_char_values(0,0)" " = 0" > gdb_test "p t_char_values('a','b')" " = 1" > gdb_test "p t_char_values(char_val1,char_val2)" " = 1" > @@ -259,6 +263,9 @@ proc do_function_calls {} { > > gdb_test "p t_structs_a(struct_val1)" "= (.unsigned char .. )? \"foo\"" \ > "call inferior func with struct - returns char *" > + > + # Restore default value. > + gdb_test_no_output "set unwindonsignal off" The patch looks right to me. Nitpicking, do we store the original value of 'unwindonsignal', and restore it here? I am wondering people may run testsuite with 'unwindonsignal' on in default? > } > > # Procedure to get current content of all registers. > -- Yao