From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31506 invoked by alias); 12 Sep 2012 19:04:25 -0000 Received: (qmail 31493 invoked by uid 22791); 12 Sep 2012 19:04:23 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Sep 2012 19:04:08 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8CJ41bD031046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Sep 2012 15:04:01 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8CJ40Jt005733; Wed, 12 Sep 2012 15:04:00 -0400 Message-ID: <5050DC9F.9050500@redhat.com> Date: Wed, 12 Sep 2012 19:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Tom Tromey CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] MI notification on record started and stopped References: <1347434118-10931-1-git-send-email-yao@codesourcery.com> <1347434118-10931-3-git-send-email-yao@codesourcery.com> <877grz5d4s.fsf@fleche.redhat.com> In-Reply-To: <877grz5d4s.fsf@fleche.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00224.txt.bz2 On 09/12/2012 07:06 PM, Tom Tromey wrote: >>>>>> "Yao" == Yao Qi writes: > > Yao> This patch is to add the MI notification on record started and > Yao> stopped. > > Yao> + fprintf_unfiltered (mi->event_channel, "record-%s,id=\"%d\"", > Yao> + started ? "started" : "stopped", inferior->num); > > Other MI notifications seem to use "i%d" when identifying an inferior. > Yeah, and they use the thread group terminology (of which only inferiors are supported currently, but could be extended towards itsets). So for consistency IMO, this would best be thread-group=\"i%d\"". -- Pedro Alves