Re: [PATCH 5/6] gdb/dwarf: store addr/offset/ref_addr sizes in dwarf2_per_cu

Simon Marchi
2025-11-21T19:55:30Z

On 2025-11-19 11:14, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> + /* Sizes for an address, an offset, and a section offset. These fields are
> Simon> + set by cutu_reader when the unit is read. */
> Simon> + unsigned char m_addr_size = 0;
> Simon> + unsigned char m_offset_size = 0;
> Simon> + unsigned char m_ref_addr_size = 0;
>
> How about uint8_t instead.

I don't mind doing that change, but why do you think it's better than
"unsigned char" here?

Simon