From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11987 invoked by alias); 11 Sep 2012 09:05:17 -0000 Received: (qmail 11970 invoked by uid 22791); 11 Sep 2012 09:05:15 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms3.broadcom.com (HELO mms3.broadcom.com) (216.31.210.19) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Sep 2012 09:05:03 +0000 Received: from [10.9.200.133] by mms3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 11 Sep 2012 02:02:37 -0700 X-Server-Uuid: B86B6450-0931-4310-942E-F00ED04CA7AF Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB02.corp.ad.broadcom.com (10.9.200.133) with Microsoft SMTP Server id 8.2.247.2; Tue, 11 Sep 2012 02:04:17 -0700 Received: from [10.177.73.63] (unknown [10.177.73.63]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id DF2239F9F6 for ; Tue, 11 Sep 2012 02:04:52 -0700 (PDT) Message-ID: <504EFEB5.60908@broadcom.com> Date: Tue, 11 Sep 2012 09:05:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [PATCH]: ptype of pointer to typedef References: <50447C4A.8010009@broadcom.com> <87a9wxevc5.fsf@fleche.redhat.com> In-Reply-To: <87a9wxevc5.fsf@fleche.redhat.com> Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00149.txt.bz2 On 10/09/2012 4:44 PM, Tom Tromey wrote: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> The test case builds on an existing test that was marked as > Andrew> xfail in a few cases, I've extended the xfail to cover the new > Andrew> case I've added, but I have no way to check if this is the right > Andrew> thing to do or not, I'm happy to change the patch if anyone has > Andrew> an opinion. > > I would just drop the xfails. > If they are needed, somebody with the affected environment can write them. Done. > > The patch is ok with that change. > > Andrew> +gdb_test "ptype pv_char_array" "type = (|unsigned )char > Andrew> \\(\\*\\)\\\[0?\\\]" > Andrew> + > > Your email got wrapped somehow. Apologies. Committed with the above change. Thanks, Andrew