From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11162 invoked by alias); 10 Sep 2012 18:32:10 -0000 Received: (qmail 11154 invoked by uid 22791); 10 Sep 2012 18:32:09 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_PGP_INLINE,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Sep 2012 18:31:53 +0000 Received: by lbon3 with SMTP id n3so1496339lbo.0 for ; Mon, 10 Sep 2012 11:31:51 -0700 (PDT) Received: by 10.152.125.116 with SMTP id mp20mr13422013lab.19.1347301911582; Mon, 10 Sep 2012 11:31:51 -0700 (PDT) Received: from [192.168.4.39] (broadband-95-84-200-156.nationalcablenetworks.ru. [95.84.200.156]) by mx.google.com with ESMTPS id g6sm2452857lby.0.2012.09.10.11.31.49 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 10 Sep 2012 11:31:49 -0700 (PDT) Message-ID: <504E3212.5070206@gmail.com> Date: Mon, 10 Sep 2012 18:32:00 -0000 From: LRN User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Thunderbird/18.0a1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32 References: <503E575D.1000608@gmail.com> <83y5kvp0za.fsf@gnu.org> <5040DA38.2070802@gmail.com> <504D4EE1.5010507@gmail.com> <87obldd9s4.fsf@fleche.redhat.com> In-Reply-To: <87obldd9s4.fsf@fleche.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00132.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10.09.2012 22:15, Tom Tromey wrote: >>>>>> "LRN" == LRN writes: > > LRN> diff --git a/gdb/infcmd.c b/gdb/infcmd.c [...] > > LRN> +#if W32_JITDBG LRN> +void LRN> +signal_event_command (char > *args, int from_tty) LRN> +{ > > Two notes here. > > First, does it make sense to put this in windows-nat.c instead? (I > don't know anything about the Windows port...) It doesn't matter > hugely. Probably. I'll try to move it there and see how it goes. > Second, it is odd to call this a _command and give it the above > prototype. Normally this convention is used for things which are > really commands -- visible to the user from the gdb CLI. > > I suppose this is so you can use catch_command_errors; but it seems > like you could equally well use catch_errors. I mostly copied the code around it. Since this is something related to attaching, i started with attach command. Probably not the best choice, since it's not what i thought it was :) > LRN> + struct cleanup *back_to = make_cleanup (null_cleanup, > NULL); > > You don't need a null cleanup unless you plan to make other > cleanups. But AFAICT there aren't any. I thought that null cleanup is to be able to call error() > LRN> + dont_repeat (); /* Not for the faint of heart */ > > You only need this for a real command. > OK. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQTjIQAAoJEOs4Jb6SI2CwoN4IAKMCSafAb2SzzIzon/J38rpn 1naD4umbbBstbzMVUqesU8NmrdRWqlOjuWbpsXd8anruKvfMk2jFZpftzqIWXzZb df8E5wBFLMH8JECWDGU8DUGJA/bBOmfswa2R9aGTgvaWya/fLcPzXmij3DQWy5sW kXxa9IQidKe30v6XE40lUbwd6ThWGjBLDW/N3CGOmQyOmmWMCV97f1o1A/k/CmM7 x4MI3YJ4u16GVIaLTiiegAnhAu2AjupbV+7TI97bLWvRMAhI2f+KyM8XX5hceTul qToORY6T/aS1Gij/RSDKSPzA19BqVLAH80BS1d0n3gqKptRt4wXRDE157tAZugY= =YWbM -----END PGP SIGNATURE-----