From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2825 invoked by alias); 7 Sep 2012 17:47:37 -0000 Received: (qmail 2804 invoked by uid 22791); 7 Sep 2012 17:47:35 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Sep 2012 17:47:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q87HlF1Z008856 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Sep 2012 13:47:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q87HlBpJ005458; Fri, 7 Sep 2012 13:47:12 -0400 Message-ID: <504A331F.2090204@redhat.com> Date: Fri, 07 Sep 2012 17:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Kaushik Phatak CC: Mike Frysinger , "gdb-patches@sourceware.org" , Yao Qi , Pedro Alves Subject: Re: [RFC] New GDB Port CR16 References: <503B9E59.6050502@codesourcery.com> <504478D0.4040202@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00071.txt.bz2 On 09/04/2012 07:49 AM, Kaushik Phatak wrote: > Hi Pedro, >> Is this dependency on host signal defines what is done on other sims? > This was probably added when breakpoint support was being added to this > sim port with reference of the SH port I believe. > >> there is cruft like this in other sims. it probably would be desirable to clean it up. > Yes Mike, I agree. I have tested it without this hunk and breakpoints seem to > work as expected. Please see below the patch that reverts this in sim. > I am rearranging some code to create cr16-linux-tdep.c file as suggested by Yao > and will post the gdb related patches soon. > Thanks! > > > 2012-09-03 Kaushik Phatak > > sim/cr16/ChangeLog: > * interp.c: Clean SIGBUS related macro. > > --- gdb_src.orig/sim/cr16/interp.c 2012-09-04 12:08:34.000000000 +0530 > +++ gdb_src/src/sim/cr16/interp.c 2012-06-18 05:04:17.000000000 +0530 > @@ -1192,11 +1192,7 @@ sim_resume (SIM_DESC sd, int step, int s > iaddr = imem_addr ((uint32)PC); > if (iaddr == State.mem.fault) > { > -#ifdef SIGBUS > State.exception = SIGBUS; > -#else > - State.exception = SIGSEGV; > -#endif > break; > } Looks obvious enough to me. Though, we should really get away with using host signals for this stuff, using sim/gdb's own signal numbers instead. For a rainy day, perhaps... -- Pedro Alves