From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11769 invoked by alias); 3 Sep 2012 15:43:51 -0000 Received: (qmail 11760 invoked by uid 22791); 3 Sep 2012 15:43:49 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Sep 2012 15:43:16 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q83FhF3C023047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Sep 2012 11:43:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q83FhDHE022004; Mon, 3 Sep 2012 11:43:14 -0400 Message-ID: <5044D011.8020700@redhat.com> Date: Mon, 03 Sep 2012 15:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix a bug on uploading tsv References: <1346686250-17361-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1346686250-17361-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00021.txt.bz2 On 09/03/2012 04:30 PM, Yao Qi wrote: > gdb/gdbserver: > > 2012-09-03 Yao Qi > > * tracepoint.c (cmd_qtsv): Adjust debug message. > Remove an incorrect condition checking. OK, thanks. Note that "incorrect" is a more of a _why_ than a _what_. A _what_ entry would be something like: 2012-09-03 Yao Qi Remove an incorrect condition check. * tracepoint.c (cmd_qtsv): Adjust debug message. Don't check CUR_TPOINT. -- Pedro Alves