From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94254-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2214 invoked by alias); 31 Aug 2012 08:22:39 -0000
Received: (qmail 2206 invoked by uid 22791); 31 Aug 2012 08:22:37 -0000
X-SWARE-Spam-Status: No, hits=-3.1 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED
X-Spam-Check-By: sourceware.org
Received: from lvk-gate.cmc.msu.ru (HELO mail.lvk.cs.msu.su) (188.44.42.233)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 31 Aug 2012 08:22:16 +0000
Received: from mail.lvk.cs.msu.su (localhost [127.0.0.1])	by mail.lvk.cs.msu.su (Postfix) with ESMTP id 989B627E;	Fri, 31 Aug 2012 12:22:10 +0400 (MSK)
X-Spam-ASN:
Received: from [192.168.0.112] (h86-62-88-129.ln.rinet.ru [86.62.88.129])	by mail.lvk.cs.msu.su (Postfix) with ESMTPSA id 82AD21B1;	Fri, 31 Aug 2012 12:22:10 +0400 (MSK)
Message-ID: <50407434.5000207@cs.msu.su>
Date: Fri, 31 Aug 2012 08:22:00 -0000
From: Vladimir Prus <ghost@cs.msu.su>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
MIME-Version: 1.0
To: Yao Qi <yao@codesourcery.com>
CC: gdb-patches@sources.redhat.com
Subject: Re: [PATCH 3/3] suppress notification
References: <1346060757-30130-1-git-send-email-yao@codesourcery.com> <1346060757-30130-4-git-send-email-yao@codesourcery.com> <k1gn65$89p$1@ger.gmane.org> <504070AE.4090703@codesourcery.com>
In-Reply-To: <504070AE.4090703@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-AV-Checked: ClamAV using ClamSMTP
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00883.txt.bz2

On 31.08.2012 12:07, Yao Qi wrote:
> On 08/28/2012 05:00 AM, Vladimir Prus wrote:
>>> +  /* If non-null, the pointer to a flag indicates that this function
>>> is being
>>> +     called.  */
>>> +  int *called;
>>
>> But in practice, this is pointer that points to notification that must
>> be supressed when this
>> command is running. So, at least the comment is misleading. And if some
>> other code will
>> want to check whether the current command is A, it would have to look at
>> notification
>> flags.
>>
>> So, at the very least, this field should have a different name, I think.
> Vladimir,
> The field name is changed to 'suppress_notification' with some comments
> update.  How about this one?

Yao,

I have no objections to this version.

Thanks,
Volodya