Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
	Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove obsolete gdbarch_static_transform_name
Date: Thu, 25 Jun 2020 10:18:00 +0100	[thread overview]
Message-ID: <503ab954-fc05-ba9b-6418-32ca92e466bb@redhat.com> (raw)
In-Reply-To: <ydd5zbfo8j5.fsf_-_@CeBiTec.Uni-Bielefeld.DE>

On 6/25/20 9:26 AM, Rainer Orth wrote:
>  	case 'X':
> -	  /* SunPRO (3.0 at least) static variable encoding.  */
> -	  if (gdbarch_static_transform_name_p (gdbarch))
> -	    goto normal;
>  	  /* fall through */
>  

If you're leaving the 

  case 'X':

then I think you should leave a comment in place about that
is about.

But I'd just remove that case X line, since the fallthrough
is to the default case anyway.

Thanks,
Pedro Alves



  reply	other threads:[~2020-06-25  9:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 13:15 [RFC][PATCH] Move common handlers to sol2_init_abi Rainer Orth
2020-06-24 10:27 ` Rainer Orth
2020-06-24 14:56 ` Simon Marchi
2020-06-24 20:57   ` Rainer Orth
2020-06-25  8:23     ` [PATCH] Don't include *sol2-tdep.o on Linux/sparc* Rainer Orth
2020-06-25  9:57       ` Pedro Alves
2020-06-25 12:03         ` Rainer Orth
2020-06-25  8:26     ` [PATCH] Remove obsolete gdbarch_static_transform_name Rainer Orth
2020-06-25  9:18       ` Pedro Alves [this message]
2020-06-25 12:07         ` Rainer Orth
2020-06-25 15:20           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503ab954-fc05-ba9b-6418-32ca92e466bb@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox