From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2462 invoked by alias); 30 Aug 2012 06:40:30 -0000 Received: (qmail 2451 invoked by uid 22791); 30 Aug 2012 06:40:28 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Aug 2012 06:40:15 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1T6yQI-0002jV-3R from Yao_Qi@mentor.com ; Wed, 29 Aug 2012 23:40:14 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 29 Aug 2012 23:40:13 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Wed, 29 Aug 2012 23:40:12 -0700 Message-ID: <503F0AD3.5020007@codesourcery.com> Date: Thu, 30 Aug 2012 06:40:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: CC: Subject: Re: [PATCH 2/4] de-couple %Stop from notification: gdb References: <1345775139-13576-1-git-send-email-yao@codesourcery.com> <1345775139-13576-3-git-send-email-yao@codesourcery.com> <20535.53033.569482.293453@ruffy2.mtv.corp.google.com> In-Reply-To: <20535.53033.569482.293453@ruffy2.mtv.corp.google.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00864.txt.bz2 On 08/25/2012 02:59 AM, dje@google.com wrote: >> (struct remote_state): Move to remote.h. > > What's the reason for moving struct remote_state to remote.h? > [I did a simple grep and couldn't find a reason, I could have missing something of course.] > Having it live in remote.c means the implementation is "private" to just that file. I hesitated to move 'struct remote_state' out of remote.c, and agree with you we may keep it private. The reason I move it out is remote-notif.c:remote_notif_pending_replies uses 'remote_state' in this way, void remote_notif_pending_replies (struct notif *np) { struct remote_state *rs = get_remote_state (); .... .... getpkt (&rs->buf, &rs->buf_size, 0); If we really don't want to expose 'struct remote_state', we can keep it living in remote.c, and move function remote_notif_pending_replies to remote.c accordingly. -- Yao