Re: [commit] Update help.exp

[Yufeng Zhang <Yufeng.Zhang@arm.com>]

Hi,

On 08/13/12 22:13, dje@google.com wrote:
> Hi.
>
> fyi, I'm checking this in.
>
> 2012-08-13  Doug Evans<dje@google.com>
>
> 	* gdb.base/help.exp: Update expected output.
>
> Index: gdb.base/help.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/help.exp,v
> retrieving revision 1.59
> diff -u -p -r1.59 help.exp
> --- gdb.base/help.exp	2 Jul 2012 17:53:19 -0000	1.59
> +++ gdb.base/help.exp	13 Aug 2012 21:12:44 -0000
> @@ -506,7 +506,7 @@ gdb_test "help show complaints" "Show ma
>   # test help show confirm
>   gdb_test "help show confirm" "Show whether to confirm potentially dangerous operations\." "help show confirm"
>   # test help show convenience
> -gdb_test "help show convenience" "Debugger convenience \\(\"\\\$foo\"\\) variables\.\[\r\n\]+These variables are created when you assign them values;\[\r\n\]+thus, \"print \\\$foo=1\" gives \"\\\$foo\" the value 1\.  Values may be any type\.\[\r\n\]+A few convenience variables are given values automatically:\[\r\n\]+\"\\\$_\"holds the last address examined with \"x\" or \"info lines\",\[\r\n\]+\"\\\$__\" holds the contents of the last address examined with \"x\"\." "help show convenience"
> +gdb_test "help show convenience" "Debugger convenience \\(\"\\\$foo\"\\) variables and functions\.\[\r\n\]+Convenience variables are created when you assign them values;\[\r\n\]+thus, \"set \\\$foo=1\" gives \"\\\$foo\" the value 1\.  Values may be any type\.\[\r\n\]+A few convenience variables are given values automatically:\[\r\n\]+\"\\\$_\"holds the last address examined with \"x\" or \"info lines\",\[\r\n\]+\"\\\$__\" holds the contents of the last address examined with \"x\"\.\[\r\n\]+Convenience functions are defined via the Python API\." "help show convenience"
>   # test help show directories
>   gdb_test "help show directories" "Show the search path for finding source files\.\[\r\n\]+\\\$cwd in the path means the current working directory\.\[\r\n\]+\\\$cdir in the path means the compilation directory of the source file\..*" "help show directories"
>   # test help show editing


help.exp still fails with --without-python.  "Convenience functions are 
defined via the Python API" is printed only when HAVE_PYTHON is defined 
(see http://sourceware.org/ml/gdb-patches/2012-08/msg00342.html).

The following is the snippet of the log file that shows the failure.


help show convenience^M
Debugger convenience ("$foo") variables and functions.^M
Convenience variables are created when you assign them values;^M
thus, "set $foo=1" gives "$foo" the value 1.  Values may be any type.^M
^M
A few convenience variables are given values automatically:^M
"$_"holds the last address examined with "x" or "info lines",^M
"$__" holds the contents of the last address examined with "x".^M
(gdb) FAIL: gdb.base/help.exp: help show convenience



Thanks,
Yufeng