From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3923 invoked by alias); 28 Aug 2012 14:09:11 -0000 Received: (qmail 3905 invoked by uid 22791); 28 Aug 2012 14:09:09 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Aug 2012 14:08:54 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7SE8r53013909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 Aug 2012 10:08:53 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7SE8pmX000984; Tue, 28 Aug 2012 10:08:52 -0400 Message-ID: <503CD0F3.4070807@redhat.com> Date: Tue, 28 Aug 2012 14:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Yao Qi CC: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [PATCH 3/3] suppress notification References: <1346060757-30130-1-git-send-email-yao@codesourcery.com> <1346060757-30130-4-git-send-email-yao@codesourcery.com> <503C7A1D.6040909@codesourcery.com> <503CB1F0.3020009@cs.msu.su> <503CC302.8060900@codesourcery.com> <503CCA27.7070607@redhat.com> <503CCC7A.8040805@codesourcery.com> In-Reply-To: <503CCC7A.8040805@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00831.txt.bz2 On 08/28/2012 02:49 PM, Yao Qi wrote: > On 08/28/2012 09:39 PM, Pedro Alves wrote: >> >> Alternatively, set the notification suppression down in the command callback itself. >> I mention it for completeness. Maybe you've considered it, and decided against it. >> > > Are you suggesting that we can set breakpoint suppression flag in each breakpoint related CLI commands, such as "delete breakpoint", "disable breakpoint", and so forth? Not really a strong suggestion, but more like it seemed like the obvious first choice to me, so I wondered if you considered and discarded it. You wouldn't do it within the CLI commands. Instead you'd expand: { "break-delete", { "delete breakpoint", 1 }, NULL }, into something like { "break-delete", { NULL, 0 }, mi_cmd_break_delete }, and then mi_cmd_break_delete would suppress the notification and call "delete breakpoint" itself. Or a core API function to break the CLI dependency (which might be a good idea anyway). -- Pedro Alves